1734161 - TB 91 not opening cid: links

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[tlhackque]

Attachment: Email demonstrating a PDF attachment that fails to open.

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36

Steps to reproduce:

Updated to TB 91.1.2 from 78.14.0 (Windows 10).

Click on the document link in the attached (cut down) e-mail. (This will work with the file on disk - that is, not in a mailbox.)

Actual results:

PDF does not open. I have tried with PDF set to "Always ask", "Preview in Thunderbird", and "Use Adobe Acrobat Reader DC (Default)".

Note that hovering over the link shows it to be active, but clicking on it produces no result. Nothing opens. No error messsage. Just dead.

Right-clicking on the link and selecting "Save As" will save the file correctly - so the data IS accessible to TB.

Expected results:

Clicking on the document link in the same message in 78.14 opens the PDF.

It should in 91 too!

This worked on the same machine (same user profile) in 78.14 (and many versions prior).

It still works (same file) on another machine that has not be updated.

Note that I have manually edited the sample message to remove a lot of headers, html and other (image) attachments that aren't necessary to show this issue. The resulting artifacts are expected.

The problem occurs in the unmodified message, both on disk and in a mailbox.

Comment 1

[Magnus Melin [:mkmelin]]

<a href="cid:1.2578-8f77e462-11c0-49e7-80a8-c7585f41a015">Document001.pdf</a>

I don't think it has anything to do with pdf or not. cid: links are not considered. They are rare - I don't think this was ever reported. Must be from the reworked link opening.

Comment 2

[tlhackque]

(In reply to Magnus Melin [:mkmelin] from comment #1)

<a href="cid:1.2578-8f77e462-11c0-49e7-80a8-c7585f41a015">Document001.pdf</a>

I don't think it has anything to do with pdf or not. cid: links are not considered. They are rare - I don't think this was ever reported. Must be from the reworked link opening.

You are probably right - I said "PDF" because that's where I experienced this as soon as I updated. In complete emails from this application, this is a table that may have many such links (thus the three digit number!).

FWIW, The full e-mail also uses cid: links for images (e.g. logos); these are correctly displayed. So it would seem to be link opening, not all uses of the cid: link type.

I wouldn't be surprised if cid: links are also used for other types of attachments in this application; I haven't gotten there yet, since not opening PDFs is serious enough to stop roll-out of TB 91 here.

Thanks for looking at this so quickly!

Comment 3

[tlhackque]

It's unusual for me to push for action on an open bug - but this regression is impacting me daily.

However rare they may be in your experience, cid: links are common here...

Since they worked in TB 78 and are handled correctly for inline images in 91, I would think that restoring the code to properly open them would not require a lot of invention. This is a regression...

I'd appreciate it if someone could have a look at this. And at least change the state from "NEW" to "CONFIRMED"... [:mkmelin] 's reply that "cid: links are not considered" seems like confirmation to me.

Thanks for whatever anyone can do to prioritize a fix.

Comment 4

[Ping Chen [:rnons] (away)]

Attachment: Bug 1734161 - Fix opening cid: link from messagepane. r=mkmelin

Use window actor to redirect to msgHdrView, so that cid link is handled the same way as click on an attachment.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90a72158a17f
Fix opening cid: link from messagepane. r=mkmelin

Comment 6

[Rob Lemley [:rjl]]

The patch in comment 4 doesn't apply to c-esr91. Will need a c-esr91 patch to fix this in 91.x.

Comment 7

[Magnus Melin [:mkmelin]]

102 is coming up soon. Let's skip 91 then.