1734174 - Verify (and remove unnecessary) implicitJSContext usage in Streams code

Status: RESOLVED FIXED

(Core :: DOM: Streams, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

A number of ReadableStreams classes request implicitJSContext in Bindings.conf. This may be un-necessary, as most of the use of that JSContext is for rooting. If that is the only use of a JSContext, then rooting can instead be provided using JS::RootingContext* rcx = RootingCx().

Comment 1

[Bryan Thrall [:bthrall]]

A lot of the ReadableStream functions use JSContext for a mix of rooting and script-running, that will have to wait for Bug 1756661, but there are a couple places we could switch over to JS::RootingContext.

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: Bug 1734174 - Remove unneeded JSContext parameter to ReadableStreamReaderGenericInitialize() r?mgaudet

Comment 3

[Bryan Thrall [:bthrall]]

Attachment: Bug 1734174 - Remove unneeded JSContext parameter from SetUpReadableStreamDefaultReader() r?mgaudet

Depends on D139868

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1734174 - Remove unneeded JSContext parameter from SetUpReadableStreamBYOBReader() r?mgaudet

Depends on D139869

Comment 5

[Bryan Thrall [:bthrall]]

Attachment: Bug 1734174 - Remove unneeded JSContext parameter to AcquireReadableStreamBYOBReader() r?mgaudet

Depends on D139870

Comment 6

[Bryan Thrall [:bthrall]]

Attachment: Bug 1734174 - Remove unneeded JSContext parameter from AcquireReadableStreamDefaultReader() r?mgaudet

Depends on D139871

Comment 7

[Bryan Thrall [:bthrall]]

Attachment: Bug 1734174 - Remove unneeded implicitJSContext from ReadableStream::GetReader() r?mgaudet

Depends on D139872

Comment 8

[Bryan Thrall [:bthrall]]

Attachment: Bug 1734174 - Remove unneeded JSContext from TeeState r?mgaudet

Depends on D139873

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86aed4d08255
Remove unneeded JSContext parameter to ReadableStreamReaderGenericInitialize() r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/fd428746ed38
Remove unneeded JSContext parameter from SetUpReadableStreamDefaultReader() r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/eeb08511438b
Remove unneeded JSContext parameter from SetUpReadableStreamBYOBReader() r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/f1ce60b1fd47
Remove unneeded JSContext parameter to AcquireReadableStreamBYOBReader() r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/49b42a210fe4
Remove unneeded JSContext parameter from AcquireReadableStreamDefaultReader() r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/9b89aba4d3ff
Remove unneeded implicitJSContext from ReadableStream::GetReader() r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/0ae9df73405a
Remove unneeded JSContext from TeeState r=mgaudet

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/86aed4d08255
https://hg.mozilla.org/mozilla-central/rev/fd428746ed38
https://hg.mozilla.org/mozilla-central/rev/eeb08511438b
https://hg.mozilla.org/mozilla-central/rev/f1ce60b1fd47
https://hg.mozilla.org/mozilla-central/rev/49b42a210fe4
https://hg.mozilla.org/mozilla-central/rev/9b89aba4d3ff
https://hg.mozilla.org/mozilla-central/rev/0ae9df73405a