1734187 - Improve HCM for the new upgrade dialog (variations button, "not now" link button)

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Comment 1

[Itiel]

Attachment: Bug 1734187 - Improve HCM for the new upgrade dialog r?mardak,#desktop-theme-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd4ab2ac7bcc
Improve HCM for the new upgrade dialog r=Mardak

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bd4ab2ac7bcc

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I’ve just verified this fix, and I’ve noticed the following:

• The “Not now” button from the Onboarding page of New Users is not visible on hover.
• The “Thank you for choosing us!” message from the fifth slide is not visible.
  @Itiel, should we log new issues for these behaviors?

Comment 5

[Itiel]

(In reply to Simona Rosu [:srosu], Ecosystem QA from comment #4)

I’ve just verified this fix, and I’ve noticed the following:

• The “Not now” button from the Onboarding page of New Users is not visible on hover.
• The “Thank you for choosing us!” message from the fifth slide is not visible.
  @Itiel, should we log new issues for these behaviors?

Thanks, AFAICT these are going to be fixed in bug 1733690.

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9244374 [details]
Bug 1734187 - Improve HCM for the new upgrade dialog r?mardak,#desktop-theme-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: High contrast users have no contrast on some upgrade spotlight buttons
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes comment 4
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Turn on high contrast

2. Open upgrade spotlight

• List of other uplifts needed: none
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): There's a known HCM regression on about:welcome as this patch changes shared common.inc.css that will be fixed with bug 1733690 (currently landing).
• String changes made/needed: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244374 [details]
Bug 1734187 - Improve HCM for the new upgrade dialog r?mardak,#desktop-theme-reviewers

In the interest of getting this fix into 94 ASAP for QA, we're going to take this into 94.0b5 without bug 1733690. We'll aim to get that fixed in 94.0b6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac881cb261fa

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

This enhancement was part of the work done on QA-1202 "MR2 onboarding (intro, theme, thank you) updates to about:welcome and upgrade spotlight" feature which was signed off as GREEEN.

Considering the above I am marking this enhancement as Verified.