Reader Recs: VQA – CTA + Recs Variant
Categories
(Firefox :: Pocket, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: gsuntop, Assigned: gsuntop)
References
Details
Attachments
(1 file, 1 obsolete file)
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by gsuntop@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/b2d87e3eff37 VQA fixes for reader recs variant r=thecount
|
||
Comment 4•3 years ago
|
||
Backed out for causing mochitest failures on browser_all_files_referenced.js.
|
|
Assignee | |
Updated•3 years ago
|
Pushed by gsuntop@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/638b250cd645 VQA fixes for reader recs variant r=thecount
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
|
||
Comment 7•3 years ago
|
||
The file pocket-outline.svg was deliberately moved to toolkit in bug 1726385 because it's referenced by a toolkit stylesheet and not having it there causes problems for other toolkit apps. Please put it back.
|
|
Assignee | |
Comment 8•3 years ago
|
||
Hi, Geoff. I see no code that points to the global/skin/icons/pocket-outline.svg path in MC at this point.
All CSS is pointing to browser/skin/pocket-outline.svg in MC.
https://searchfox.org/mozilla-central/search?q=pocket-outline.svg&path=
The pocket-outline.svg I removed should be unused at this point AFAIK. Having it there was actually causing a test to fail. Can you give me more detail on the issue removing it is causing (eg: link me to code). Thanks.
|
|
||
Comment 9•3 years ago
|
||
The problem isn't that code is pointing to a missing file. It's that a file in toolkit is pointing to a file in browser, which must not be done because not everything that uses toolkit has the files from browser. For example Thunderbird, or even Firefox mobile AIUI.
So what I was asking for is to move the file back to toolkit and update the references to it. I'm now doing that in bug 1698112 anyway so there's nothing to be done here.
Description
•