Closed Bug 1734266 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 30780 - [GridNG] Invalidate when alignment changes on OOF elements

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30780 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30780
Details from upstream follow.

Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com> wrote:

[GridNG] Invalidate when alignment changes on OOF elements

This change will trigger a full relayout when alignment
changes on out-of-flow grid items without a grid area in
order to properly layout with dynamic changes.

Bug: 1248940
Change-Id: If22f77dee0caaaf2fcd17a9b50d91ad9ea7e179f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159264
Commit-Queue: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Reviewed-by: Daniel Libby \<dlibby@microsoft.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Ethan Jimenez \<ethavar@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#927440}

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c387d5ce3a6 [wpt PR 30780] - [GridNG] Invalidate when alignment changes on OOF elements, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.