Closed Bug 1734327 Opened 3 years ago Closed 3 years ago

dom/media/MediaFormatReader.cpp:14:10: fatal error: 'AOMDecoder.h: No such file or directory' , when compiling with --disable-av1

Categories

(Core :: Audio/Video: Playback, defect, P2)

Firefox 95
defect

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- fixed

People

(Reporter: herrtimson, Assigned: alwu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

I checked out latest copy of firefox-nightly source code and compiled it.

Actual results:

the build is broken with a missing header:

8:30.23 In file included from Unified_cpp_dom_media2.cpp:74:
8:30.23 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-95.0/work/firefox-95.0/dom/media/MediaFormatReader.cpp:14:10: fatal error: AOMDecoder.h: No such file or directory
8:30.23 14 | #include "AOMDecoder.h"
8:30.23 | ^~~~~~~~~~~~~~
8:30.23 compilation terminated.
8:30.23 In file included from /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-95.0/work/firefox_build/dist/include/nsTArray.h:3331,

Expected results:

I expect the build to pass.

Regressed by: 1730020
Has Regression Range: --- → yes
Summary: AOMDecoder header is missing in nightly → dom/media/MediaFormatReader.cpp:14:10: fatal error: 'AOMDecoder.h: No such file or directory' , when compiling with --disable-av1
Keywords: regression
Assignee: nobody → alwu
Severity: -- → N/A
Status: UNCONFIRMED → NEW
Type: defect → task
Component: Untriaged → Audio/Video: Playback
Ever confirmed: true
Priority: -- → P2
Product: Firefox → Core
Type: task → defect
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e32259cf0ac
only use AOMDecoder when MOZ_AV1 is defined. r=bryce

that fixed it, thank you very much for the fast push :-)

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: