Closed Bug 1734334 Opened 3 years ago Closed 3 years ago

Wasm stores the address of the barrier flag using a different pointer type

Categories

(Core :: JavaScript: WebAssembly, defect, P5)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Bug 1734334 - Use correct pointer type to store address of barrier flag r?lth
48 bytes, text/x-phabricator-request
Details | Review

I just noticed that the Wasm barrier code takes a pointer to Zone::needsIncrementalBarrier_ (a uint32_t) and stores it in a uint8_t*. It gets accessed using a branchTest32 so this shouldn't cause a problem.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56b34efcc724
Use correct pointer type to store address of barrier flag r=lth

https://hg.mozilla.org/mozilla-central/rev/56b34efcc724

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: