1734362 - Add some more tests for GC/CC integration

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1734362 - Add some tests for JS holder / GC integration r?mccr8

This tests that JS holders get marked gray by GC and updated when moved by
compacting GC. The latter would have caught the problem reported in bug
1731432.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1734362 - Add JSAPI tests for JS::Heap<T> read barriers during incremental GC r?sfink

Depends on D127670

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f118a3deafc
Add some tests for JS holder / GC integration r=mccr8
https://hg.mozilla.org/integration/autoland/rev/211f5803783a
Add JSAPI tests for JS::Heap<T> read barriers during incremental GC r=sfink

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1734392 for bustages on TestJSHolderMap.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/8eee170a2362db3b783ace0a3733614e09435cb7

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=53f7d8f6758a2127b3d8a698016a65e535bc9f96&selectedTaskRun=SBiKws4nSMaXSNXDHPXsjw.0

• failure log: https://treeherder.mozilla.org/logviewer?job_id=354116136&repo=autoland&lineNumber=68607

[task 2021-10-08T10:12:03.651Z] 10:12:03     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/tests/gtest'
[task 2021-10-08T10:12:03.658Z] 10:12:03     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/MacOSX10.12.sdk -mmacosx-version-min=10.12 -stdlib=libc++ -std=gnu++17 --target=x86_64-apple-darwin -o TestJSHolderMap.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/xpcom/tests/gtest -I/builds/worker/workspace/obj-build/xpcom/tests/gtest -I/builds/worker/checkouts/gecko/xpcom/base -I/builds/worker/checkouts/gecko/toolkit/components/telemetry/tests/gtest -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wshadow-uncaptured-local -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/TestJSHolderMap.o.pp   /builds/worker/checkouts/gecko/xpcom/tests/gtest/TestJSHolderMap.cpp
[task 2021-10-08T10:12:03.659Z] 10:12:03    ERROR -  /builds/worker/checkouts/gecko/xpcom/tests/gtest/TestJSHolderMap.cpp:181:20: error: use of undeclared identifier 'HoldJSObjects'; did you mean 'mozilla::HoldJSObjects'?
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -    ObjectHolder() { HoldJSObjects(this); }
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -                     ^~~~~~~~~~~~~
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -                     mozilla::HoldJSObjects
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/HoldDropJSObjects.h:65:6: note: 'mozilla::HoldJSObjects' declared here
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -  void HoldJSObjects(T* aHolder) {
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -       ^
[task 2021-10-08T10:12:03.659Z] 10:12:03    ERROR -  /builds/worker/checkouts/gecko/xpcom/tests/gtest/TestJSHolderMap.cpp:202:21: error: use of undeclared identifier 'DropJSObjects'; did you mean 'mozilla::DropJSObjects'?
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -    ~ObjectHolder() { DropJSObjects(this); }
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -                      ^~~~~~~~~~~~~
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -                      mozilla::DropJSObjects
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/HoldDropJSObjects.h:74:6: note: 'mozilla::DropJSObjects' declared here
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -  void DropJSObjects(T* aHolder) {
[task 2021-10-08T10:12:03.659Z] 10:12:03     INFO -       ^

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bf7f12bc23b
Add some tests for JS holder / GC integration r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9bd8c94de16b
Add JSAPI tests for JS::Heap<T> read barriers during incremental GC r=sfink

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5bf7f12bc23b
https://hg.mozilla.org/mozilla-central/rev/9bd8c94de16b