Closed Bug 1734388 Opened 2 months ago Closed 2 months ago

Figure out how to hide errors in `tgdiff` task

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

The tgdiff task updates version control to the parent of the push. If the push in question is making changes to areas that affect taskcluster/taskgraph/main.py itself, then the task can sometimes fail with an exception, like in this case

While these failures are harmless and expected, they cause confusion for sheriffs. I don't want to simply make the task tier 3, since it provides value to folks and hiding it will make it hard to find.

Another way to avoid confusion here would be to suppress errors (so the task is always green). Though in this case we might miss legitimate errors. Also tgdiff is kind of acting as a unittest here because it is validating that all the parameters under taskcluster/test/params pass generation (though we should probably stand up a proper unittest that does this anyway).

Maybe a good compromise here would be to suppress errors that happen only when generating on the parent revision (and still fail on errors that happen from the current revision).

The 'tgdiff' task can fail if you are working on the 'taskgraph' module itself
and the parent revision isn't compatible with your changes.

This ensures the 'tgdiff' task stays green if there was a failure on the
parent, but still turns orange if there was a failure on the current revision
(since that is likely a legit error)

Assignee: nobody → ahal
Status: NEW → ASSIGNED
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef74b203af82
Suppress 'tgdiff' failures on the base revision, r=taskgraph-reviewers,aki
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.