Closed Bug 1734389 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31133 - [credentialless] Fix WPT interactions.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31133 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31133
Details from upstream follow.

Arthur Sonzogni <arthursonzogni@chromium.org> wrote:

[credentialless] Fix WPT interactions.

When run with the official WPT test runner, the COEP credentialless are
failing pretty often compared to Chrome's test runner:
https://wpt.fyi/results/html/cross-origin-embedder-policy/credentialless?label=experimental
The reason is that test aren't run in isolation. Cookies added for one
test are kept for the next one. This shouldn't be a problem for COEP
credentialless, because every test use a different key.

However, there was a problem parsing the cookie value. Chrome insert
spaces and new lines in the cookie value.

Previously:

coep_credentialless_script=xxx;
coep_credentialless_link=yyy

was parsed as:

{
  "coep_credentialess_script": "xxx",
  " coep_credentialless_link": "yyy",
}

causing the test to fail when run in sequence.

Solution was to properly trim the values, to remove extra spaces.

Fixed:1254649
Bug:1254649
Change-Id: Ic0d51c5b6a8422a8a1f3a9348a54d707f71f7b02

Reviewed-on: https://chromium-review.googlesource.com/3208052
WPT-Export-Revision: 6a875e1eb4754a33934217f053cb5770eb323bcf

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 31 tests and 30 subtests

Status Summary

Firefox

OK : 27
PASS : 149
FAIL : 44
TIMEOUT: 29

Chrome

OK : 31
PASS : 191
FAIL : 27

Safari

OK : 27
PASS : 122
FAIL : 76
TIMEOUT: 9
ERROR : 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.html?1-4
COEP:require-corp embeds same-origin COEP:credentialless: FAIL linked bug:Bug 1715581
/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.html?9-last
COEP:require-corp embeds same-origin COEP:credentialless, CORP:cross-origin: FAIL linked bug:Bug 1715581
COEP:require-corp embeds cross-origin COEP:credentialless, CORP:cross-origin: FAIL linked bug:Bug 1715581
/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.html?5-9
COEP:require-corp embeds same-origin COEP:credentialless, CORP:cross-origin: FAIL linked bug:Bug 1715581
/html/cross-origin-embedder-policy/credentialless/reporting-navigation.tentative.https.html: TIMEOUT linked bug:Bug 1717187
/html/cross-origin-embedder-policy/reporting-navigation.https.html: TIMEOUT linked bug:Bug 1720106

New Tests That Don't Pass

/html/cross-origin-embedder-policy/anonymous-iframe/anonymous-iframe-popup.tentative.https.html
Cross-origin popup from normal/anonymous iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Same-origin popup from normal/anonymous iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/anonymous-iframe/cookie.tentative.https.html
Anonymous same-origin iframe is loaded without credentials: FAIL (Chrome: FAIL, Safari: FAIL)
Anonymous cross-origin iframe is loaded without credentials: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send same_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send cross_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send cross_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send same_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send same_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send cross_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send cross_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send same_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/anonymous-iframe/local-storage.tentative.https.html
same_origin anonymous iframe can't access the localStorage: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't access the localStorage: FAIL (Chrome: FAIL, Safari: PASS)
/html/cross-origin-embedder-policy/credentialless/cache-storage.tentative.https.html?dedicated_worker
[dedicated_worker] unsafe-none => credentialless: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/cache-storage.tentative.https.html?document
[document] unsafe-none => credentialless: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/cache-storage.tentative.https.html?service_worker
[service_worker] unsafe-none => credentialless: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/cache-storage.tentative.https.html?shared_worker
[shared_worker] unsafe-none => credentialless: FAIL (Chrome: FAIL)
/html/cross-origin-embedder-policy/credentialless/cache.tentative.html
The HTTP cache must not be used: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/cross-origin-isolated.html
Main crossOriginIsolated case:: FAIL (Chrome: PASS, Safari: FAIL)
Report-only + enforced:: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/dedicated-worker.tentative.https.html
fetch same-origin: FAIL (Chrome: PASS, Safari: FAIL)
fetch cross-origin: FAIL (Chrome: PASS, Safari: FAIL)
fetch cross-origin + credentialless worker: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/fetch.tentative.https.html
fetch cross-origin + no-cors + credentials:include: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/iframe-coep-credentialless.tentative.https.html?1-4
COEP:credentialless embeds same-origin COEP:none: FAIL (Chrome: PASS, Safari: FAIL)
COEP:credentialless embeds cross-origin COEP:none: FAIL (Chrome: PASS, Safari: FAIL)
COEP:credentialless embeds cross-origin COEP:credentialless: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/iframe-coep-credentialless.tentative.https.html?5-9
COEP:credentialless embeds cross-origin COEP:require-corp: FAIL (Chrome: PASS, Safari: FAIL)
COEP:credentialless embeds same-origin COEP:none, CORP:cross-origin: FAIL (Chrome: PASS, Safari: FAIL)
COEP:credentialless embeds cross-origin COEP:none, CORP:cross-origin: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.html?1-4
COEP:require-corp embeds same-origin COEP:credentialless: FAIL (Chrome: PASS, Safari: PASS)
/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.html?9-last
COEP:require-corp embeds same-origin COEP:credentialless, CORP:cross-origin: FAIL (Chrome: PASS, Safari: PASS)
COEP:require-corp embeds cross-origin COEP:credentialless, CORP:cross-origin: FAIL (Chrome: PASS, Safari: PASS)
/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.html?5-9
COEP:require-corp embeds same-origin COEP:credentialless, CORP:cross-origin: FAIL (Chrome: PASS, Safari: PASS)
/html/cross-origin-embedder-policy/credentialless/image.tentative.https.html
image cross-origin + undefined: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/link.tentative.https.html
link cross-origin + undefined: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/redirect.tentative.html
same-origin -> cross-origin: FAIL (Chrome: PASS, Safari: FAIL)
cross-origin -> same-origin: FAIL (Chrome: PASS, Safari: FAIL)
cross-origin -> cross-origin: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/reporting-navigation.tentative.https.html: TIMEOUT (Chrome: OK, Safari: OK)
parent: |header(cross-origin-embedder-policy,credentialless), target: |header(cross-origin-embedder-policy,credentialless), : TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,credentialless), target: (none), : TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,credentialless), target: |header(cross-origin-resource-policy,cross-origin), : TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,credentialless), target: |header(cross-origin-embedder-policy,credentialless), : TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,credentialless), target: (none), : TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,credentialless), target: |header(cross-origin-resource-policy,cross-origin), : TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,credentialless), target: |header(cross-origin-embedder-policy-report-only,credentialless)|header(cross-origin-resource-policy,cross-origin), : TIMEOUT (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/script.tentative.https.html
script cross-origin + undefined: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/service-worker-coep-credentialless-proxy.tentative.https.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
COEP:credentialless ServiceWorker: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/html/cross-origin-embedder-policy/credentialless/service-worker-coep-none-proxy.tentative.https.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
COEP:unsafe-none ServiceWorker: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/html/cross-origin-embedder-policy/credentialless/service-worker.tentative.https.html
fetch cross-origin + credentialless worker: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/credentialless/shared-worker.tentative.https.html
fetch cross-origin + credentialless worker: FAIL (Chrome: FAIL, Safari: TIMEOUT)
/html/cross-origin-embedder-policy/credentialless/video.tentative.https.window.html
video cross-origin + undefined: FAIL (Chrome: PASS, Safari: FAIL)
/html/cross-origin-embedder-policy/reporting-navigation.https.html: TIMEOUT (Chrome: OK, Safari: OK)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-embedder-policy,require-corp), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-embedder-policy,require-corp), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: (none), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: (none), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-resource-policy,cross-origin), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-resource-policy,cross-origin), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,require-corp), target: |header(cross-origin-embedder-policy,require-corp), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,require-corp), target: |header(cross-origin-embedder-policy,require-corp), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,require-corp), target: (none), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,require-corp), target: (none), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,require-corp), target: |header(cross-origin-resource-policy,cross-origin), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy-report-only,require-corp), target: |header(cross-origin-resource-policy,cross-origin), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-embedder-policy-report-only,require-corp)|header(cross-origin-resource-policy,cross-origin), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-embedder-policy-report-only,require-corp)|header(cross-origin-resource-policy,cross-origin), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-resource-policy,cross-origin)|header(x-frame-options,deny), with empty frame: false: TIMEOUT (Chrome: PASS, Safari: FAIL)
parent: |header(cross-origin-embedder-policy,require-corp), target: |header(cross-origin-resource-policy,cross-origin)|header(x-frame-options,deny), with empty frame: true: TIMEOUT (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c27f5562b07
[wpt PR 31133] - [credentialless] Fix WPT interactions., a=testonly

https://hg.mozilla.org/mozilla-central/rev/1c27f5562b07

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.