1734396 - x5u should be fetched with Utils.fetch instead of fetch

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement)

Description

[Rob Wu [:robwu]]

Everything in RemoteSettings uses Utils.fetch to fetch remote data (since bug 1654693 and bug 1729009).

Well, everything except _validateCollectionSignature: https://searchfox.org/mozilla-central/rev/1dab956095020c53aa66cbee8845eb1fa925b75c/services/settings/RemoteSettingsClient.jsm#863

That should also use Utils.fetch.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1734396 - Use Utils.fetch to fetch x5u

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c0659816956
Use Utils.fetch to fetch x5u r=leplatrem

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1c0659816956

Comment 4

[Rob Wu [:robwu]]

Comment on attachment 9244544 [details]
Bug 1734396 - Use Utils.fetch to fetch x5u

Beta/Release Uplift Approval Request

• User impact if declined: RemoteSettings may fail to apply changes depending on network conditions.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The underlying logic is already used by other parts of RemoteSettings, and has received full automated test coverage in bug 1729009.
• String changes made/needed:

Comment 5

[Dianna Smith [:diannaS]]

Approved for 94.0b6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/37ba694f1fb9