173446 - nsUnicodeMappingUtil needs a scrubbing

Status: RESOLVED WONTFIX

(Core :: Internationalization, defect)

Description

[timeless]

while looking into bug 58221, we ran into this code...

problems:
290 sfraser    1.18 void PR_CALLBACK
291                 nsUnicodeMappingUtil::PrefEnumCallback(const char* aName,
void* aClosure)
292 dbaron     1.22 {	

* shouldn't allocate new nsAutoString:
333                   PRUnichar valueInUCS2[FACESIZE]= { 0 };
334                   PRUnichar format[] = { '%', 's', 0 };
335 sford3     1.5    PRUint32 n = nsTextFormatter::snprintf(valueInUCS2,
FACESIZE, format, valueInUTF8);
336 ftang      1.4    Recycle(valueInUTF8);
337                   if(n == 0)
338                   	return;     
339                   nsString *fontname = new nsAutoString(valueInUCS2);
340                   if(nsnull == fontname)
341                   	return;
342                   short fontID=0;
343                   if( (! nsDeviceContextMac::GetMacFontNumber(*fontname,
fontID)) ||

* same in
371                 void nsUnicodeMappingUtil::InitScriptFontMapping()
372                 {

* should probably be a service
492                 nsUnicodeMappingUtil* nsUnicodeMappingUtil::GetSingleton()

Comment 1

[Rui Xu]

code issue, QA to [e-mail] for now.

Comment 2

[Simon Montagu :smontagu]

Source file no longer exists