Closed Bug 1734478 Opened 3 years ago Closed 3 years ago

stop checking displayport size against max texture size

Categories

(Core :: Panning and Zooming, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(2 files)

No description provided.

No longer necessary, and it only NS_ASSERTION'd if we failed anyway, and we weren't even checking on mac and android due to the tiling pref.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED

The reason that GetDisplayPortForVisibilityTesting was using Drop was because there is a test that sets a 10x zoom and we ran image visibility without updating the displayport base rect (painting would update it), so the returned displayport was based on the much larger base rect. The patches goal was to avoid the assert we removed. Using a displayport that large in that situation for image visibility seems fine because it shouldn't make us decode any more images then were previously already visible.

Depends on D127731

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/811ec184b294
Stop checking displayport size against max texture size. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/2226e24d027d
Remove MaxSizeExceededBehaviour from displayport getter options as it is unused. r=botond
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: