1734523 - m-c build fails if no mozconfig is present

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Glenn Watson [:gw]]

Running ./mach build on latest m-c fails if there is no mozconfig file present:

 0:12.97 Traceback (most recent call last):
 0:12.97   File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
 0:12.97     return _run_code(code, main_globals, None,
 0:12.97   File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
 0:12.97     exec(code, run_globals)
 0:12.97   File "/home/gw/code/work/gecko1/python/mozbuild/mozbuild/action/webidl.py", line 20, in <module>
 0:12.97     sys.exit(log_build_task(main, sys.argv[1:]))
 0:12.97   File "/home/gw/code/work/gecko1/python/mozbuild/mozbuild/action/util.py", line 18, in log_build_task
 0:12.97     return f(*args, **kwargs)
 0:12.97   File "/home/gw/code/work/gecko1/python/mozbuild/mozbuild/action/webidl.py", line 15, in main
 0:12.97     manager = BuildSystemWebIDL.from_environment().manager
 0:12.97   File "/home/gw/code/work/gecko1/dom/bindings/mozwebidlcodegen/__init__.py", line 695, in manager
 0:12.97     "--enable-dom-streams" in self.mozconfig["configure_args"]
 0:12.97 TypeError: argument of type 'NoneType' is not iterable

Comment 1

[Mike Hommey [:glandium]]

"--enable-dom-streams" in self.mozconfig["configure_args"]

Yeah, that's really not how this should be checked for. And there's a similar construct in layout/tools/reftest/mach_commands.py coming from bug 1642661 and build/mach_initialize.py inherited from bug 1291335.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1734523 - Make MozbuildObject.mozconfig* return an empty dict rather than None when there is no mozconfig.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1734523 - Remove the use of MozbuildObject.mozconfig in mozwebidlcodegen.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1734523 - Remove the use of MozbuildObject.mozconfig in run_jstestbrowser.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1734523 - Remove the use of MozbuildObject.mozconfig in mach_initialize.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46ee9f72b436
Remove the use of MozbuildObject.mozconfig in mozwebidlcodegen. r=firefox-build-system-reviewers,mhentges

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cab1ceba09dd
Remove the use of MozbuildObject.mozconfig in run_jstestbrowser. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/dcd0fedade7e
Remove the use of MozbuildObject.mozconfig in mach_initialize. r=firefox-build-system-reviewers,mhentges

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/46ee9f72b436

Comment 10

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1734523) for causing python failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/b589691183767d6198bf42dcc7522b240db71c2c
Push with failures, failure log.
Update: also caused puppeteer failures.

Comment 11

[Mike Hommey [:glandium]]

The issue this was filed for was fixed by what ended up being merged in central. I'll move the remaining to bug 1734754.

Comment 12

[Phabricator Automation]

Comment on attachment 9244696 [details]
Bug 1734523 - Remove the use of MozbuildObject.mozconfig in run_jstestbrowser.

Revision D127766 was moved to bug 1734754. Setting attachment 9244696 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9244697 [details]
Bug 1734523 - Remove the use of MozbuildObject.mozconfig in mach_initialize.

Revision D127767 was moved to bug 1734754. Setting attachment 9244697 [details] to obsolete.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1730589