Closed
Bug 1734542
Opened 3 years ago
Closed 3 years ago
[DoH] In steering detection, replace references to the provider's "name" property with "id" instead
Categories
(Firefox :: Security, defect, P1)
Firefox
Security
Tracking
()
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: nhnt11, Assigned: nhnt11)
References
Details
Attachments
(1 file)
I'm not sure why we're checking a "name" attribute here. Since the remote settings schema doesn't include a name attribute, effectively provider steering is broken. This has been the case since we switched over to remote settings for steering, around the beginning of June.
|
Assignee | |
Comment 1•3 years ago
|
||
Hmm, so we do use the name attribute for recording telemetry. It's also included in the provider steering test which uses remote settings. I think the bug is actually that we're using "id" as a non-user-facing name for providers in RS schema... we should use it.
Summary: [DoH] In steering detection, don't check if the provider's "name" property is falsy → [DoH] In steering detection, replace references to the provider's "name" property with "id" instead
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b0248d28425a [DoH] In steering detection, replace references to the provider's "name" property with "id" instead. r=necko-reviewers,valentin
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•