1734625 - Add more diagnostic asserts for ScriptPreloader cache alignment

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[Tooru Fujisawa [:arai]]

bug 1734612 sounds like file corruption.
to verify that, add more assertion to ScriptPreloader::WriteCache.

If the crash in ScriptPreloader::InitCacheInternal still happens, it means the crash is caused by file corruption,
and in that case we should add fallback path to ignore the cache, instead of crashing.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1734625 - Add more diagnostic asserts for ScriptPreloader cache alignment. r?nbp!

Depends on D127866

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80adf467d998
Add more diagnostic asserts for ScriptPreloader cache alignment. r=nbp

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/80adf467d998

Comment 5

[Tooru Fujisawa [:arai]]

Comment on attachment 9244831 [details]
Bug 1734625 - Add more diagnostic asserts for ScriptPreloader cache alignment. r?nbp!

Beta/Release Uplift Approval Request

• User impact if declined: This is diagnostic patch for bug 1734612, to check if the crash is caused by file corruption or not.
  This patch doesn't have testcase. we'll monitor the crash stats.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1734624
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds release asserts that basically shouldn't hit unless there's data corruption.
  If these assertions don't hit and bug 1734612 crash keeps happening, it means there's file corruption and we'll handle it.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244831 [details]
Bug 1734625 - Add more diagnostic asserts for ScriptPreloader cache alignment. r?nbp!

Approved for 94.0b4.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9453702c406e