Closed Bug 1734667 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30983 - Add credentials to same-origin Report uploads

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30983 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30983
Details from upstream follow.

Ian Clelland <iclelland@chromium.org> wrote:

Add credentials to same-origin Report uploads

When the reporting endpoint is same-origin with the page generating
reports, the reporting API specifies that credentials should be included
with the report delivery.

This change enables that behaviour for V1 reporting endpoints only --
any endpoints configured with the Report-To header are unaffected. This
CL corrects the way that we distinguish V0 from V1 endpoints at delivery
time, which also corrects the metrics collection for delivered reports,
and adds a test for a case which was previously missed.

Bug: 1163645
Change-Id: I8fcd934b3026b57374e7e7df31c9af9a8d93962d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169200
Reviewed-by: Matt Menke \<mmenke@chromium.org>
Reviewed-by: Maksim Orlovich \<morlovich@chromium.org>
Reviewed-by: Ken Buchanan \<kenrb@chromium.org>
Reviewed-by: Mike West \<mkwst@chromium.org>
Reviewed-by: Christian Dullweber \<dullweber@chromium.org>
Commit-Queue: Ian Clelland \<iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929239}

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 3

Chrome

OK : 3
FAIL: 3

Safari

OK : 3
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/reporting/cross-origin-same-site-credentials.https.sub.html
Reporting endpoints received credentials.: FAIL (Chrome: FAIL, Safari: FAIL)
/reporting/same-origin-cross-site-credentials.https.sub.html
Reporting endpoints received credentials.: FAIL (Chrome: FAIL, Safari: FAIL)
/reporting/same-origin-same-site-credentials.https.sub.html
Reporting endpoints received credentials.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65c36558dfff
[wpt PR 30983] - Add credentials to same-origin Report uploads, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e5c80760ff45
[wpt PR 30983] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/65c36558dfff
https://hg.mozilla.org/mozilla-central/rev/e5c80760ff45

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.