1734731 - Glean.shutdown in qt errors.

Status: RESOLVED FIXED

(Data Platform and Tools Graveyard :: Glean.js, defect, P1)

Description

[Sarah Bird]

Warning: qrc:/glean/org/mozilla/Glean/glean.js:102: TypeError: Property 'shutdown' of object [object Object] is not a function (glean.js:102)

The function in glean.js is

/**
 * Finishes executing any ongoing tasks and shuts down Glean.
 *
 * This will attempt to send pending pings before resolving.
 *
 * @returns A promise which resolves once shutdown is complete.
 */
function shutdown() {
  return Glean.shutdown();
}

I have a suspicion it should be Glean.Glean.default.shutdown() in the way that Glean.initialize looks like this

/**
 * Initialize Glean. This method should only be called once, subsequent calls will be no-op.
 *
 * @param applicationId The application ID (will be sanitized during initialization).
 * @param uploadEnabled Determines whether telemetry is enabled.
 *        If disabled, all persisted metrics, events and queued pings (except
 *        first_run_date) are cleared.
 * @param config Glean configuration options.
 */
function initialize(applicationId, uploadEnabled, config) {
  Glean.Glean.default.initialize(applicationId, uploadEnabled, config);
}

Comment 1

[Beatriz Rizental [:brizental]]

I have a suspicion it should be Glean.Glean.default.shutdown() in the way that Glean.initialize looks like this

Yes you are 100% right here. Woof that was an ooversight, I will have a fix later today.

Comment 2

[Beatriz Rizental [:brizental]]

Attachment: GitHub Pull Request

Comment 3

[Beatriz Rizental [:brizental]]

Work on Bug 1708194 uncovered this issue as well so I applied the fixes for it there.