1734738 - Uneven spacing around "all threads" checkbox

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Markus Stange [:mstange]]

Attachment: Screen Shot 2021-10-07 at 7.32.57 PM.png

See the screenshot. The "Bypass selections above and record all registered threads" line has uneven spacing: there's space above but not below.
This makes it easier to miss the checkbox when scanning visually across this section.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1734738 - [aboutprofiling] Adjust the space around the checkbox to select all threads r=jdescottes

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1734738 - [aboutprofiling] Disable all threads checkboxes when the 'all threads' checkbox is checked r=jdescottes

Depends on D128099

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39004de98ca3
[aboutprofiling] Adjust the space around the checkbox to select all threads r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/cb13dc106ff9
[aboutprofiling] Disable all threads checkboxes when the 'all threads' checkbox is checked r=jdescottes

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures on browser_aboutprofiling-threads.js
Backout link : https://hg.mozilla.org/integration/autoland/rev/459bd5c39bf55293ac1b470db3e544f223f5b26b
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=cb13dc106ff9c32459274806a2c0f0bb05ecd831&selectedTaskRun=YLFHQDH7TmKnN3R4EQuxkg.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=354486111&repo=autoland&lineNumber=3155

Comment 5

[Julien Wajsberg [:julienw]]

my punishment for not pushing to try

Comment 6

[Julien Wajsberg [:julienw]]

Here is a new try with the fixes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b27caf13a0e17b5fa2b158a5a833b9a4c3bcb7aa

Comment 7

[Julien Wajsberg [:julienw]]

The new try looks much better, relanding!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed5613ee53a
[aboutprofiling] Adjust the space around the checkbox to select all threads r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/660b572e3049
[aboutprofiling] Disable all threads checkboxes when the 'all threads' checkbox is checked r=jdescottes

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8ed5613ee53a
https://hg.mozilla.org/mozilla-central/rev/660b572e3049