Closed Bug 1734761 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31163 - ReadableStream: Fix respond() after enqueue() with multiple pending reads

Categories

(Core :: JavaScript Engine, task, P4)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31163 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31163
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

ReadableStream: Fix respond() after enqueue() with multiple pending reads

The previous fix to calling respond() after enqueue() did not work
correctly when there were multiple pending calls to read(). Fix it.

Fixed: 1255762,1257465
Change-Id: I3f2dad7c3970c37579ee955491f74bbc7d70e456
Reviewed-on: https://chromium-review.googlesource.com/3213786
WPT-Export-Revision: bd84973ce7dd81bffd8c9bf1539e710620f32cb1

PR 31163 applied with additional changes from upstream: 73ff424533dc6b1277ab978b3be72cafebf7299c
Component: web-platform-tests → JavaScript Engine
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 3 subtests

Status Summary

Firefox

OK : 4
FAIL : 12

Chrome

CRASH: 4

Safari

OK : 3
FAIL : 9
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/streams/readable-byte-streams/respond-after-enqueue.any.js: SKIP (Chrome: SKIP, Safari: SKIP)
/streams/readable-byte-streams/respond-after-enqueue.any.sharedworker.html
byobRequest.respond() after enqueue() should not crash: FAIL
byobRequest.respond() with cached byobRequest after enqueue() should not crash: FAIL
byobRequest.respond() after enqueue() with double read should not crash: FAIL
/streams/readable-byte-streams/respond-after-enqueue.any.html
byobRequest.respond() after enqueue() should not crash: FAIL (Safari: FAIL)
byobRequest.respond() with cached byobRequest after enqueue() should not crash: FAIL (Safari: FAIL)
byobRequest.respond() after enqueue() with double read should not crash: FAIL (Safari: FAIL)
/streams/readable-byte-streams/respond-after-enqueue.any.worker.html
byobRequest.respond() after enqueue() should not crash: FAIL (Safari: FAIL)
byobRequest.respond() with cached byobRequest after enqueue() should not crash: FAIL (Safari: FAIL)
byobRequest.respond() after enqueue() with double read should not crash: FAIL (Safari: FAIL)
/streams/readable-byte-streams/respond-after-enqueue.any.serviceworker.html
byobRequest.respond() after enqueue() should not crash: FAIL (Safari: FAIL)
byobRequest.respond() with cached byobRequest after enqueue() should not crash: FAIL (Safari: FAIL)
byobRequest.respond() after enqueue() with double read should not crash: FAIL (Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/streams/readable-byte-streams/respond-after-enqueue.any.js: SKIP (Chrome: SKIP, Safari: SKIP)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd41b5456a75
[wpt PR 31163] - ReadableStream: Fix respond() after enqueue() with multiple pending reads, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fd41b5456a75

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.