Open Bug 1734768 Opened 3 years ago Updated 2 years ago

Duplication of breakpoints in the browser toolbox

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: bomsy, Assigned: bomsy)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-future, dt-perf-stability-mvp)

Attachments

(3 obsolete files)

Prefs:

  • fission.autostart => true
  • devtools.target-switching.server.enabled => true
  • fission.bfcacheInParent => true

I have STRs for duplicated breakpoints, but with the Browser Toolbox.

Here are my STRs:

  1. open Firefox on any page (eg the default about:newtab)
  2. open the Multiprocess Browser Toolbox
  3. in the MBT, open the Debugger, find the source resource://devtools/server/actors/resources/console-messages.js
  4. set a breakpoint at L217 (in prepareConsoleMessageForRemote, const result = WebConsoleUtils.cloneObject(message);)
  5. close the MBT, and reopen it

ER: You should only see one breakpoint
AR: There are 3 identical breakpoints listed in the breakpoints panel. Every time you restart the MBT there is an additional breakpoint.

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED

Comment on attachment 9250361 [details]
Bug 1734768 - [devtools] Stop showing duplicates

Revision D130968 was moved to bug 1740980. Setting attachment 9250361 [details] to obsolete.

Attachment #9250361 - Attachment is obsolete: true
Attachment #9246435 - Attachment is obsolete: true
Attachment #9250185 - Attachment is obsolete: true
Attachment #9250185 - Attachment is obsolete: false
Attachment #9246435 - Attachment is obsolete: false

Bomsy, is anything blocking us from completing this bug?

Flags: needinfo?(hmanilla)

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #5)

Bomsy, is anything blocking us from completing this bug?

The patch for making pending breakpoints unique is likely not the way we want to go with moving to breakpoints per url.

But the second patch a can actually be completed and landed as it useful in showing expose the thread info about the breakpoint.
This will make it less confusing, at least till we fix the duplication it.

I'll update both patches.

Thanks

Flags: needinfo?(hmanilla)
Attachment #9246435 - Attachment is obsolete: true
See Also: → 1755344

Comment on attachment 9250185 [details]
Bug 1734768 - [devtools] Show the thread info in breakpoint list tooltip

Revision D130866 was moved to bug 1755960. Setting attachment 9250185 [details] to obsolete.

Attachment #9250185 - Attachment is obsolete: true
See Also: → 1755960

Additional STRs can be found in Bug 1759975 comment #0 and Bug 1759975 comment #1

Depends on: 1769787
Depends on: 1780172
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: