1734834 - Show MR2 upgrade dialog on windows 7

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Bug 1731834 changed the triggering behavior in 94 to specially exclude windows 7. New decision is to show as the new colorways seem to not be affected by bug 1702480. Assuming QA is good, we'll want this uplifted to 94.

Comment 1

[Ed Lee :Mardak]

There's a test file dependency on bug 1734461, which split out triggers to own test.

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1734834 - Show MR2 upgrade dialog on windows 7 r?andreio

Remove win7 restriction and related helpers and tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/730d5a3ad7ad
Show MR2 upgrade dialog on windows 7 r=andreio

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/730d5a3ad7ad

Comment 5

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the "Colorway" spotlight is displayed in the Upgrading Users Onboarding flow using Firefox Nightly 95.0a1 en-US (Build ID: 20211011084036) on Windows 7 x64. Given that we are in the Preliminary testing phase, a more thorough investigation will be done on the Firefox Beta channel once this is uplifted, as part of the feature testing which is tracked in QA-1202.

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

Hey @Ed,

Can you please request an uplift for this issue to hopefully get it in the next Beta build?

Comment 7

[Ed Lee :Mardak]

Comment on attachment 9244978 [details]
Bug 1734834 - Show MR2 upgrade dialog on windows 7 r?andreio

Beta/Release Uplift Approval Request

• User impact if declined: Windows 7 users upgrading to 94 will not see upgrade spotlight with the new colorways
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Trigger upgrade spotlight on windows 7
• List of other uplifts needed: Bug 1734461
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removes the explicit check preventing windows 7 from showing the dialog. Patch depends on bug 1734461
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244978 [details]
Bug 1734834 - Show MR2 upgrade dialog on windows 7 r?andreio

Approved for 94.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dfb9ad99998d

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

Marking this issue as Verified based on the work done for the feature. For more information see QA-1202.