1734858 - [Fission] Apply the fix for bug 1725680 also to bfcached pages

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

There is one case where bug 1725680 didn't deal with bfcached pages. A patch coming

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1734858, use the real index when updating the index after a bfcache load, r=peterv

The issue is that when going back from a non-bfcacheable page to a bfcacheable page and the first page
modifies requested index around the same time, UpdateIndex() doesn't have the right requested index. This is a variant of bug 1725680.
The test case loads a non-bfcacheable page, then bfcachable, then another non-bfcacheable and then goes back and forward.
Without the patch indexes go wrong and forward doesn't do anything.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01abda14e67b
use the real index when updating the index after a bfcache load, r=peterv

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/01abda14e67b

Comment 4

[Chris Peterson [:cpeterson]]

Olli, should we uplift your index fix to Beta 94 for Fission MVP?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Yes

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9244993 [details]
Bug 1734858, use the real index when updating the index after a bfcache load, r=peterv

Beta/Release Uplift Approval Request

• User impact if declined: Going back or forward in the session history may not do what the user expects
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fixes a very specific edge case when a non-bfcached page modifies session history just when we're about to load a page from bfcache
• String changes made/needed:

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9244993 [details]
Bug 1734858, use the real index when updating the index after a bfcache load, r=peterv

Approved for 94.0b6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/85b8f606034c