1734861 - Show colorway about:welcome screen on windows 7

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

We're showing upgrade spotlight for windows 7 with bug 1734834, so most likely we'll want to show colorway for windows 7 during new user onboarding too.

Comment 1

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]: we are uplifting similar fix in 94 for upgrade dialog , see bug 1734834

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1734861 - Show colorway about:welcome screen on windows 7

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ea5f47b182
Show colorway about:welcome screen on windows 7 r=Mardak

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/63ea5f47b182

Comment 5

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the "Life in color" slide is displayed in the New Users Onboarding flow using Firefox Nightly 95.0a1 en-US (Build ID: 20211011084036) on Windows 7 x64. Given that we are in the Preliminary testing phase, a more thorough investigation will be done on the Firefox Beta channel once this is uplifted, as part of the feature testing which is tracked in QA-1202.

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

Hey @Punam,

Can you please request an uplift for this issue to hopefully get it in the next Beta build?

Comment 7

[Ed Lee :Mardak]

Comment on attachment 9245020 [details]
Bug 1734861 - Show colorway about:welcome screen on windows 7

Beta/Release Uplift Approval Request

• User impact if declined: New users on windows 7 don't see the new colorways
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open about:welcome on windows 7

2. Go through screens until colorways

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removes special windows 7 colorway screen removal
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245020 [details]
Bug 1734861 - Show colorway about:welcome screen on windows 7

Approved for 94.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/66a169dad675

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

Marking this issue as Verified based on the work done for the feature. For more information see QA-1202.