1734886 - Implement DOM TransformStreams

Status: RESOLVED FIXED

(Core :: DOM: Streams, task, P3)

Comment 1

[Tom S [:evilpie]]

Attachment: WIP: Draft: Bug 1734886 - Implement DOM TransformStreams (Sketch)

I sort of stopped working on this when I realized I would have to go add all UnderlyingSink, UnderlyingSource and probably also UnderlyingTransformer.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Intend to work on this, but feel free to take this if anyone wants to start working on this this week.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 1: Throw when readably/writableType fields exist r=mgaudet

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 2: Initialize [[controller]] slot of TransformStream r=mgaudet

Depends on D138825

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d43d0e3ba23
Part 1: Throw when readably/writableType fields exist r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/874b3fe4de86
Part 2: Initialize [[controller]] slot of TransformStream r=mgaudet

Comment 6

[Atila Butkovits]

Backed out for causing Hazard bustages at TransformStream.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b27d027a75f46e3403e98d99db8c5d0f9db73b90

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=874b3fe4de8626ac13f9ddd041ba6dbb0c5c9c5f&selectedTaskRun=Qvnln9W5SNW_egzU6yj9sA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=368147818&repo=autoland&lineNumber=102096

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf03d2b9d9fd
Part 1: Throw when readably/writableType fields exist r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3d025c374794
Part 2: Initialize [[controller]] slot of TransformStream r=mgaudet

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bf03d2b9d9fd
https://hg.mozilla.org/mozilla-central/rev/3d025c374794

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 3: Add [[transformAlgorithm]] internal slot r=evilpie,mgaudet

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ca7fd5a9d1
Part 3: Add [[transformAlgorithm]] internal slot r=mgaudet

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 4: Add missing reference symbol &

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/034dd1b461f5
Part 4: Add missing reference symbol & CLOSED TREE

Comment 13

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/77ca7fd5a9d1
https://hg.mozilla.org/mozilla-central/rev/034dd1b461f5

Comment 14

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 5: Implement InitializeTransformStream r=evilpie,mgaudet

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32e1a02fdd2c
Part 5: Implement InitializeTransformStream r=mgaudet

Comment 16

[Atila Butkovits]

Backed out for causing bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4132f7fe450eca978c629f55dbaaf4932a475224

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Q6lpRU5UQg2G8hfc0RJHfQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=32e1a02fdd2cc451cfe3f936d69c2d77d376da9e

Failure log: https://treeherder.mozilla.org/logviewer?job_id=372097964&repo=autoland&lineNumber=8920

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/544d6892423d
Part 5: Implement InitializeTransformStream r=mgaudet

Comment 18

[Atila Butkovits]

Backed out for causing failures attransform-stream.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6049e7dc8971a94de36f3207be48522344bf1986

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=544d6892423de047d5c8dd618cee1d50eb1b0fb0&selectedTaskRun=cJpyUl97R16mXcBLiUb-qA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=372113103&repo=autoland&lineNumber=1953

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff5b26e3dd36
Part 5: Implement InitializeTransformStream r=mgaudet

Comment 20

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ff5b26e3dd36

Comment 21

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 6: Store FlushCallback in TransformStream r=evilpie,mgaudet

This itself does not provide any additional feature, since nothing uses the callbacks yet.

Comment 22

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 7: Implement TransformStreamDefaultController::GetDesiredSize r=evilpie,mgaudet

Depends on D141974

Comment 23

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 8: Implement TransformStreamDefaultController methods r=evilpie,mgaudet

Depends on D141975

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b01ead158136
Part 6: Store FlushCallback in TransformStream r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e02ef90f9411
Part 7: Implement TransformStreamDefaultController::GetDesiredSize r=mgaudet

Comment 25

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing hybrid bustages in TransformerCallbackHelpers. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/867b48058bde75ef267dc0620b39b3398a56989d

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=e02ef90f9411820401760d22809ad467f2c07ade&selectedTaskRun=KYmQSj8gQnajI_TwsOM5XA.0

Link to failure log:
https://treeherder.mozilla.org/logviewer?job_id=372302250&repo=autoland&lineNumber=22740
https://treeherder.mozilla.org/logviewer?job_id=372302240&repo=autoland&lineNumber=26069

Failure message:
/builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:49:37: error: member access into incomplete type 'mozilla::dom::TransformStream'
gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: TransformerCallbackHelpers.obj] Error 1

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff46ecafba0c
Part 6: Store FlushCallback in TransformStream r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c2c4e6832c5e
Part 7: Implement TransformStreamDefaultController::GetDesiredSize r=mgaudet

Comment 27

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ff46ecafba0c
https://hg.mozilla.org/mozilla-central/rev/c2c4e6832c5e

Comment 28

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 9: Add Promise::ThenWithCycleCollectedArgsJS r=smaug!,mgaudet!

Depends on D142013

Comment 29

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734886 - Part 10: Implement transform sink/source algorithms r=mgaudet,evilpie

Depends on D142151

Comment 30

[Matthew Gaudet (he/him) [:mgaudet]]

If we don't get all the patches on this bug landed before the release split, I'd recommend we close this and open another, to avoid having a bug with patches crossing releases.

Comment 31

[Kagami Rosylight [:saschanaz] (they/them)]

Does it matter when none of them are enabled in the release? 👀

Comment 32

[Matthew Gaudet (he/him) [:mgaudet]]

It's not a hard and fast rule, but personally I like it; allows easier reasoning about what's in what release.

If you'd prefer to keep everything here, that's fine (by me).

Comment 33

[Kagami Rosylight [:saschanaz] (they/them)]

I'd like to keep them here, given that it hasn't been enabled anywhere and thus has nothing to do with "what's in what release". Splitting would be kinda confusing IMO at this point.

(But I generally agree with that)

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2efe409b3da
Part 8: Implement TransformStreamDefaultController methods r=mgaudet

Comment 35

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2efe409b3da

Comment 36

[Kagami Rosylight [:saschanaz] (they/them)]

Even though I said comment #33, I actually want to split the promise part to bug 1762661 and the last patch 10 to another new one. I'll close this.

Comment 37

[Phabricator Automation]

Comment on attachment 9269525 [details]
Bug 1734886 - Part 9: Add Promise::ThenWithCycleCollectedArgsJS r=smaug!,mgaudet!

Revision D142151 was moved to bug 1762661. Setting attachment 9269525 [details] to obsolete.

Comment 38

[Phabricator Automation]

Comment on attachment 9269696 [details]
Bug 1734886 - Part 10: Implement transform sink/source algorithms r=mgaudet,evilpie

Revision D142228 was moved to bug 1763142. Setting attachment 9269696 [details] to obsolete.