Closed Bug 1734894 Opened 3 years ago Closed 3 years ago

Remove the gradients from the events in the views

Categories

(Calendar :: General, task)

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

The new today pane removed the gradients from the events. We should follow in the views.

Attached patch 1734894-no-event-gradient.patch (obsolete) — — Splinter Review

Remove them.

In the Day and Week view you can with dragging create an event. Now it is a orange. What do you think about this colour? Should we change it? If yes, what could we use?

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9245012 - Flags: review?(alessandro)
Comment on attachment 9245012 [details] [diff] [review]
1734894-no-event-gradient.patch

Review of attachment 9245012 [details] [diff] [review]:
-----------------------------------------------------------------

Good improvements.

As a follow up we should maybe consider using the same style we're using in the today pane to differentiate between regular and all day events, but only for the multiweek and month view.
Right now all events have the same blocky style, which makes the whole view very busy and unnecessary. The blocky style makes sense in the day/week view so you can easily identify the time extent of a meeting, but in the other views it's just mostly visual noise.

::: calendar/base/themes/common/calendar-views.css
@@ +32,5 @@
>    --viewTimeBoxColor: #6a6969;
>    --viewDayLabelSelectedColor: #000;
>    --viewDayLabelSelectedBackground: #fffabc;
>    --viewDragboxColor: -moz-dialogtext;
> +  --viewDragboxBackground: #feb822;

Here we could use #45a1ff, which is a lighter blue from the palette of our primary color. A bit more visually consistent I think.
Attachment #9245012 - Flags: review?(alessandro) → review+
Attached patch 1734894-no-event-gradient.patch — — Splinter Review

Updated the dragbox colour.

Attachment #9245012 - Attachment is obsolete: true
Attachment #9245050 - Flags: review+
Target Milestone: --- → 95 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c6a2b60fd1d3
Remove the gradients from the events in the views. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: