1734897 - Missing Create New Login > Cancel button when there are no other logins

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Sergey Galich [:serg]]

Attachment: missing-cancel.png

It looks similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1576735

Comment 1

[Alaa Elghamry]

Hello! I'm an Outreachy applicant and I'd love to work on this bug. May I be assigned, please?

Comment 2

[Sergey Galich [:serg]]

Welcome :Alaa Elghamry !

You will find this button here https://searchfox.org/mozilla-central/source/browser/components/aboutlogins/content/aboutLogins.html#362
Don't forget to look at https://searchfox.org/mozilla-central/source/browser/components/aboutlogins/content/components/login-item.css

Comment 3

[Sergey Galich [:serg]]

Clearing assignee to allow others to participate.

Comment 4

[Sergey Galich [:serg]]

:vidutomar19 ask a question when you needinfo? someone

Comment 5

[kaustubhdapurkar]

Hey, what should be the behaviour/action after clicking the CANCEL button? I was thinking of reloading the page as it should be easy to implement.

Thanks & Happy New Year! :)
Kaustubh Dapurkar.

Comment 6

[Sergey Galich [:serg]]

(In reply to kaustubhdapurkar from comment #5)

Hey, what should be the behaviour/action after clicking the CANCEL button? I was thinking of reloading the page as it should be easy to implement.

I suspect the button doesn't remove new entry from the screen and that's why it was hidden.
Reloading the page is not perfect, but can be accepted.

Comment 7

[kaustubhdapurkar]

Hi, I have made a few changes to fix this bug but I am not very confident about the changes, can someone review the changes even before they are committed? Also open to any suggestions or other approaches to achieve the same result.

Thanks,
Kaustubh Dapurkar.

Comment 8

[Sergey Galich [:serg]]

(In reply to kaustubhdapurkar from comment #7)

Hi, I have made a few changes to fix this bug but I am not very confident about the changes, can someone review the changes even before they are committed? Also open to any suggestions or other approaches to achieve the same result.

Thanks,
Kaustubh Dapurkar.

Sure, just attach your patch to this bug so we can review it.

Comment 9

[Kian]

Attachment: Bug 1734897 - Made the cancel button when creating a login visible even when there are no other logins. r?sgalich

Comment 10

[Kian]

Should I find a different reviewer the patch? Just trying to make sure this doesn't fall under the radar.

Comment 11

[Sergey Galich [:serg]]

Kian, sorry for the delay, I'll try to get to it soon.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 13

[renatoalencar.73]

Attachment: Bug 1734897 - Fix about:logins Cancel button behavior r=sgalich

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 15

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed9736cc4de3
Fix about:logins Cancel button behavior r=sgalich

Comment 17

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ed9736cc4de3

Comment 18

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ed9736cc4de3

Comment 19

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 106.0a1 en-US build (Build ID: 20220916033628) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

• The “Cancel” button is displayed in the “Create New Login” mode when no other logins are saved and performs the correct actions.