Add profiler markers for GeckoSession.onLoadRequest (UI)
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox95 fixed)
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file)
To complete a page load request from the search screen in fenix, there are three events that need to happen:
- HomeActivity.load
- GeckoSession.load (this is the call into Gecko)
- (if request is redirect) GeckoSession.onLoadRequest
If these requests don't occur synchronously, we'll schedule them on the UI thread, which in practice means page load will be blocked on the expensive (200-500ms on Moto G5) UI transition. We've seen a few issues where this happens (https://github.com/mozilla-mobile/fenix/issues/21530 & https://bugzilla.mozilla.org/show_bug.cgi?id=1734916) so adding profiler markers will be helpful to ensure these events are occurring quickly. We already have markers for the first two: this bug is for the last one.
|
Assignee | |
Comment 1•3 years ago
|
||
Here is a profile demonstrating the change (debug build):
https://share.firefox.dev/3iKNmEm
In the ac code, the GeckoResult is expected to be resolved synchronously so I
didn't think it was worth measuring the duration of this method.
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by mcomella@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/632d945b4aa3 add marker for GeckoSession.onLoadRequest. r=agi
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•