Closed Bug 1734939 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31169 - [@layer] Change layer order from preorder to postorder

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31169 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31169
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

[@layer] Change layer order from preorder to postorder

This patch follows from a recent CSSWG resolution [1] that puts the
default layer at the highest priority, and a subsequent spec edit [2]
that changed the layer ordering from the preorder of the layer tree to
the postorder.

[1] https://github.com/w3c/csswg-drafts/issues/6284#issuecomment-937262197
[2] https://github.com/w3c/csswg-drafts/commit/a6fc16e1b65868c6f984918cc76ad9b238e7139e

Fixed: 1257936
Change-Id: I899de8c8a921b0535296957ee1b0cca1f60a8c61
Reviewed-on: https://chromium-review.googlesource.com/3214603
WPT-Export-Revision: 51c5ce49c8ae16776bb42f3117a2da67d362fd2d

PR 31169 applied with additional changes from upstream: b0ddca61eb379737028ca37080392f3cca1e1eba
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 3 subtests

Status Summary

Firefox

OK : 8
PASS: 48
FAIL: 32

Chrome

OK : 8
PASS: 17
FAIL: 63

Safari

OK : 8
PASS: 17
FAIL: 63

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-cascade/layer-basic.html
A2 Anonymous layers: FAIL linked bug:Bug 1734570
A3 Anonymous layers: FAIL linked bug:Bug 1734570
B2 Named layers: FAIL linked bug:Bug 1734570
/css/css-cascade/layer-font-face-override.html
@font-face unlayered overrides layered: FAIL
/css/css-cascade/layer-import.html
A1 Layer rules with import: FAIL linked bug:Bug 1734570
A2 Layer rules with import: FAIL linked bug:Bug 1734570
A3 Layer rules with import: FAIL linked bug:Bug 1734570
B1 Anonymous imports: FAIL linked bug:Bug 1734570
C1 Named imports: FAIL linked bug:Bug 1734570
/css/css-cascade/layer-keyframes-override.html
@keyframes unlayered overrides layered: FAIL linked bug:Bug 1734570

New Tests That Don't Pass

/css/css-cascade/layer-basic.html
A2 Anonymous layers: FAIL (Chrome: PASS, Safari: PASS)
A3 Anonymous layers: FAIL (Chrome: PASS, Safari: PASS)
A5 Anonymous layers: FAIL (Chrome: FAIL, Safari: FAIL)
A6 Anonymous layers: FAIL (Chrome: FAIL, Safari: FAIL)
A7 Anonymous layers: FAIL (Chrome: FAIL, Safari: FAIL)
A8 Anonymous layers: FAIL (Chrome: FAIL, Safari: FAIL)
A9 Anonymous layers: FAIL (Chrome: FAIL, Safari: FAIL)
B2 Named layers: FAIL (Chrome: PASS, Safari: PASS)
B5 Named layers: FAIL (Chrome: FAIL, Safari: FAIL)
D2 Mixed named and anonymous layers: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-cascade/layer-counter-style-override.html
@counter-style unlayered overrides layered: FAIL (Chrome: PASS, Safari: FAIL)
@counter-style override between layers: FAIL (Chrome: FAIL, Safari: FAIL)
@counter-style override update with appended sheet 1: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-cascade/layer-font-face-override.html
@font-face unlayered overrides layered: FAIL (Chrome: PASS, Safari: PASS)
@font-face override between layers: FAIL (Chrome: FAIL, Safari: FAIL)
@font-face override update with appended sheet 1: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-cascade/layer-import.html
A1 Layer rules with import: FAIL (Chrome: PASS, Safari: PASS)
A2 Layer rules with import: FAIL (Chrome: PASS, Safari: PASS)
A3 Layer rules with import: FAIL (Chrome: PASS, Safari: PASS)
B1 Anonymous imports: FAIL (Chrome: PASS, Safari: PASS)
C1 Named imports: FAIL (Chrome: PASS, Safari: PASS)
C4 Named imports: FAIL (Chrome: FAIL, Safari: FAIL)
C9 Named imports: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-cascade/layer-keyframes-override.html
@keyframes unlayered overrides layered: FAIL (Chrome: PASS, Safari: PASS)
/css/css-cascade/layer-property-override.html
@property unlayered overrides layered: FAIL (Chrome: PASS, Safari: FAIL)
@property override between layers: FAIL (Chrome: FAIL, Safari: FAIL)
@property override update with appended sheet 1: FAIL (Chrome: FAIL, Safari: FAIL)
@property override update with appended sheet 2: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-cascade/layer-scroll-timeline-override.html
@scroll-timeline unlayered overrides layered: FAIL (Chrome: PASS, Safari: FAIL)
@scroll-timeline override between layers: FAIL (Chrome: FAIL, Safari: FAIL)
@scroll-timeline override update with appended sheet 1: FAIL (Chrome: FAIL, Safari: FAIL)
@scroll-timeline override update with appended sheet 2: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6acf80edab0e
[wpt PR 31169] - [@layer] Change layer order from preorder to postorder, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4a3819cd05c1
[wpt PR 31169] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6acf80edab0e
https://hg.mozilla.org/mozilla-central/rev/4a3819cd05c1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.