Closed Bug 1734971 Opened 3 years ago Closed 3 years ago

pylint fails to install with mach on Windows (missing colorama)

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Platform:
All
Windows
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox93 unaffected, firefox94 fixed, firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- fixed
firefox95 --- fixed

People

(Reporter: mathew.hodson, Assigned: mathew.hodson)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1734971 - Add pylint requirements for Windows.
48 bytes, text/x-phabricator-request
Details | Review

When I run mach lint, pylint fails to install.

ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    colorama from https://files.pythonhosted.org/packages/44/98/5b86278fbbf250d239ae0ecb724f8572af1c91f4a11edf4d36a206189440/colorama-0.4.4-py2.py3-none-any.whl#sha256=9f47eda37229f68eee03b24b9748937c7dc3868f906e8ba69fbcbdd3bc5dc3e2 (from pylint==2.10.2->-r C:\Users\Mathew\source\repos\mozilla-central\tools\lint\python\pylint_requirements.txt (line 47))
Unable to install correct version of pylint
Assignee: nobody → mathew.hodson

I think this is because I use python 3.7. Looking at https://github.com/PyCQA/astroid/blob/v2.7.3/setup.cfg#L43, astroid requires typing-extensions>=3.7.4 when using a python version less than 3.8. colorama is probably also a version dependent requirement.

OS: Unspecified → Windows
Hardware: Unspecified → All

pylint requires colorama on Windows. See https://github.com/PyCQA/pylint/blob/v2.10.2/setup.cfg#L50

Summary: pylint install fails with mach → pylint fails to install with mach on Windows (missing colorama)
Attachment #9245081 - Attachment description: Bug 1734971 - Regenerate pylint requirements. r?marco → Bug 1734971 - Add pylint requirements for Windows.

Hi, I am facing the same issue so I replace the pylint_requirements.txt with the patched file uploaded in this thread. However, now when I run any mach lint command i get another error.

$ ./mach lint -w -o
error: problem with lint setup, skipping android-api-lint, android-checkstyle, android-format, android-javadoc, android-lint, android-test
✖ 0 problems (0 errors, 1 warning, 0 fixed)


Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b7ad6b75099
Add pylint requirements for Windows. r=linter-reviewers,sylvestre
Blocks: 1735681
See Also: → 1648586
Regressed by: 1729222
Has Regression Range: --- → yes

https://hg.mozilla.org/mozilla-central/rev/0b7ad6b75099

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Set release status flags based on info from the regressing bug 1729222

status-firefox93: --- → unaffected
status-firefox94: --- → affected
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → unaffected
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: