1735112 - MacTouchBar.js causes PlacesUtils.jsm to be loaded before first paint

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mark Banner (:standard8)]

Running the browser/base/content/test/performance/browser_startup.js on my Mac with a touchbar, I'm seeing:

  FAIL resource://gre/modules/PlacesUtils.jsm is not allowed before first paint - 
Stack trace:
0 get image() ["file:///Users/mark/dev/gecko/objdir-ff/dist/Nightly.app/Contents/Resources/browser/components/MacTouchBar.js":574:4]

This is causing PlacesUtils and Sqlite, maybe other things to be loaded earlier in startup than necessary, potentially slowing startup down slightly.

Looking at the code, it is unclear that MacTouchBar needs to call PlacesUtils:

https://searchfox.org/mozilla-central/rev/2c4b830b924f42283632b70f39a60fd36433dd4d/browser/components/touchbar/MacTouchBar.js#574

  get image() {
    return this._image ? PlacesUtils.toURI(this._image) : null;
  }

The documentation for TouchBarInput says that it is a string: A URL pointing to an SVG internal to Firefox..

toURI is converting to an nsIURI

Therefore, I think we can probably just use Services.io.newURI or NetUtils.newURI directly as it shouldn't be an URL object.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1735112 - Avoid loading PlacesUtils.jsm in early startup from MacTouchBar.js. r?harry!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e931a1080ef9
Avoid loading PlacesUtils.jsm in early startup from MacTouchBar.js. r=harry

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e931a1080ef9