1735114 - image flickering when during dragging for the animation

Status: NEW

(Core :: Graphics: ImageLib, defect)

Description

[Karl Dubost💡 :karlcow]

1. Go to https://choq.com/product/choq-seven-wonders/
2. Grab the pills bottle
3. Drag on the side

Expected:
Rotate smoothly

Actual:
Flickering.

This is a profile.
https://share.firefox.dev/3BCw5oo

Comment 1

[Alice0775 White]

On windows10, The image animation flickers not only when you drag the image, but also when the page loads.
Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f608a5a5d8e2472396a0f4cd04778730866b8ae0&tochange=c61b11debf423499104a9c547590850f63a56fa4

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1341881

Comment 3

[Alice0775 White]

FWIW,
Setting image.decode-immediately.enabled to true fixes the flickering for me(Firefox91ESR, Nightly95.0a1 Windows10).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I guess bug 1734811 didn't help here.

Comment 5

[Timothy Nikkel (:tnikkel)]

Presumably the problem would be fixed if the site used decoding="sync" on the <image> elements. Otherwise we'd have to come up with some heuristic to try to detect situations like this and do sync decoding (we have some simple ones already). The site seems to have a series of images with display:none and then removes the display none of the image it wants to show at that time. Nothing comes to mind quickly for a heuristic to detect this.

Comment 6

[Timothy Nikkel (:tnikkel)]

Should retest after bug 1737257 is fixed.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Not really a performance issue.
Layout, styling or imglib might be more correct.

emilio, by any chance, does Stylo have some callback which is called when styling of some element is changed from display: none to something else. I'm thinking here just some element.style.display = ""; case here, but maybe it could work also in other cases.
(That wouldn't fix anything here, but could be part of the fix here)

Comment 8

[Emilio Cobos Álvarez (:emilio)]

not quite a callback but you'd enter the frame constructor / ReconstructFramesForContent and you can do whatever there