Closed Bug 1735119 Opened 3 years ago Closed 2 years ago

Add context menus to the new 3-pane window

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
96 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(5 files)

Making the context menu is easy. Making it all work … not so much.

Summary: Add a context menu to the thread pane in the new 3-pane → Add a context menus to the new 3-pane window
Depends on: 1740650
Summary: Add a context menus to the new 3-pane window → Add context menus to the new 3-pane window
Attachment #9252217 - Attachment description: WIP: Bug 1735119 - Add a context menu to the thread pane in the new 3-pane → Bug 1735119 - Add a context menu to the thread pane in the new 3-pane. r=mkmelin
Attachment #9252217 - Attachment description: Bug 1735119 - Add a context menu to the thread pane in the new 3-pane. r=mkmelin → Bug 1735119 - Add a context menu to the new thread pane and message display. r=mkmelin

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f1c1efa90b0f
Add a context menu to the folder pane in the new 3-pane window. r=mkmelin
https://hg.mozilla.org/comm-central/rev/a0837e547a9a
Add a context menu to the new thread pane and message display. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

I'm gonna add some more patches to this bug, since it's largely the same code.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

This puts the command controller more in control of the commands it handles, which has a bonus side-effect of making some of the main message menu work a bit better.

Ultimately I'd like to put the command controller in charge of all of the commands and their UI, but that may not be possible for some.

This converts each command to a separate function, which should help with readability, and means more commands can easily be added, like those which apply to about:3pane but not to about:message.

Depends on D132335

Keywords: leave-open
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/db74c5136dae
Use commands to enable/disable menu items in new 3pane. r=mkmelin
https://hg.mozilla.org/comm-central/rev/f665072bfd90
Refactor new 3pane command controller. r=mkmelin

By adding these methods to the tab modes, tabmail automatically connects <command>s in the outer window to the command controller in the inner window.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/71672b805d48
Connect the new mail tab controllers to the outer window. r=mkmelin
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Regressions: 1789120
Regressions: 1853558
Regressions: 1855065
Regressions: 1859938
Regressions: 1860539
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: