"Forget About This Site" confirmation prompt is still clearing when cancelled with the Esc key
Categories
(Toolkit :: Data Sanitization, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | unaffected |
firefox93 | --- | wontfix |
firefox94 | + | verified |
firefox95 | --- | verified |
People
(Reporter: ke5trel, Assigned: pbz)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
STR:
- Login to a site and save the password.
- Right-click a history item for the site (sidebar, library or menu) and choose "Forget About This Site".
- When the confirmation prompt appears, press the Esc key.
Expected:
Esc cancels the prompt and nothing is cleared.
Actual:
History, cookies and passwords are cleared for the site.
Clicking the Cancel button or pressing Enter/Spacebar with the Cancel button focused works as expected.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I can reproduce this. The issue is that "esc" will result in button1 which is used as "accept" here. Switching the buttons should fix this.
Assignee | ||
Comment 2•3 years ago
|
||
Pressing the X (close window button on Windows) also clears the data.
Is this case taken care of in the patch? (Sorry I don't know how to read the codes.)
Assignee | ||
Comment 4•3 years ago
|
||
(In reply to Fanolian from comment #3)
Pressing the X (close window button on Windows) also clears the data.
Is this case taken care of in the patch? (Sorry I don't know how to read the codes.)
Yes, the patch also addresses this issue. Thanks for pointing it out!
Comment 5•3 years ago
|
||
[Tracking Requested - why for this release]: Causes unintended dataloss if the user opens the dialog and tries to exit without using the "Cancel" button.
Updated•3 years ago
|
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50698f4ed7ec Fix esc key accepting the 'forget about this site' confirmation prompt. r=Standard8
Comment 7•3 years ago
|
||
bugherder |
Comment 8•3 years ago
|
||
The patch landed in nightly and beta is affected.
:pbz, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9245259 [details]
Bug 1735122 - Fix esc key accepting the 'forget about this site' confirmation prompt. r=standard8!
Beta/Release Uplift Approval Request
- User impact if declined: Firefox may clear site data unexpectedly, if users cancel the "Forget about this site" confirmation prompt via "ESC" key or by closing the prompt window.
(Note that prior to FF 93 the "Forget about this site" feature didn't have a confirmation dialog at all and would directly clear data) - Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See STR in comment 0.
You can additionally test with the window close button, instead of using the ESC key. It should result in the same behavior and not confirm the prompt / clear site data. - List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Low risk. The code change is very small and well understood. Is covered by automated tests.
- String changes made/needed:
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Comment on attachment 9245259 [details]
Bug 1735122 - Fix esc key accepting the 'forget about this site' confirmation prompt. r=standard8!
Fixes a possible dataloss issue. Thanks for including new tests for this. Approved for 94.0b8.
Comment 11•3 years ago
|
||
bugherder uplift |
Comment 12•3 years ago
|
||
Reproduced the issue with Firefox 95.0a1 (20211011214613) on Windows 10x64 and STR from comment 0.
Verified fixed with Firefox 95.0a1 (20211020093007) and 94.0b8 (20211019190240) on Windows 10x64, macOS 10.15 and Ubuntu 18.04. Clicking X
or pressing Esc
while the forget about this website prompt appears closes the window as expected and no longer confirms it.
Description
•