Closed Bug 1735250 Opened 3 years ago Closed 3 years ago

Define JEMALLOC_MAX_STATS_BINS in terms of other constants

Categories

(Core :: Memory Allocator, task)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: pbone, Assigned: pbone)

References

Details

Attachments

(1 file)

The constant JEMALLOC_MAX_STATS_BINS is defined as a number and needs to be kept in-line with other constants in mozjemalloc.cpp. If we define it in terms of those constants it'll be easier to manage.

Depends on: 1669392

jemalloc_stats takes an array for its second argument. It expects this
array to have enough space for all the bins, previously the maximum was set
as a magic number. To make it dependent on the configured bins this patch
replaces the compile-time constant with a function.

Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ae392a1e725
Provide a less-magic array size for jemalloc_stats r=glandium
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Blocks: 1737199
Regressions: 1743713
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: