Switch AudioCallbackDriver if the MediaTrack with the max channel changes
Categories
(Core :: Audio/Video: MediaStreamGraph, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: chunmin, Assigned: chunmin)
Details
Attachments
(5 files)
Suppose we have two AudioInputTrack
s. Track A is 1-channel and the Track B is 2-channel. Regardless of the opening order of the tracks, we will have a 2-channel AudioCallbackDriver
with ReevaluateInputDevice()
's help [1]. However, in the current code [2], if track B is closed before track A, the AudioCallbackDriver
stays uncanged. We won't switch to a new 1-channel AudioCallbackDriver
. We will keep using the old 2-channel one. We should change to a 1-channel AudioCallbackDriver
in this case.
[1] https://searchfox.org/mozilla-central/rev/2c4b830b924f42283632b70f39a60fd36433dd4d/dom/media/MediaTrackGraph.cpp#1220
[2] https://searchfox.org/mozilla-central/rev/2c4b830b924f42283632b70f39a60fd36433dd4d/dom/media/MediaTrackGraph.cpp#915-920
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
MockCubebStream's input channel count should be set by its parameters
for its input-side instead of a fixed constant value predefined in
MockCubeb.
Depends on D128421
Assignee | ||
Comment 3•3 years ago
|
||
Expose the destroyed stream in MockCubeb via MediaEventSource interface
so StreamDestroyEvent()'s caller have a way to check if the destroyed
stream is the expected one.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
If the max input channel count is changed in OpenAudioInputImpl, we
need a new AudioCallbackDriver
Depends on D128422
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 5•3 years ago
|
||
Add a test for AudioInputProcessing::SetRequestedInputChannelCount
Updated•3 years ago
|
Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d1c33e22f15 Switch GraphDriver when the MediaTrack with the max channel is closed r=pehrsons https://hg.mozilla.org/integration/autoland/rev/3baf00ec0434 Expose destroyed stream in MockCubeb via MediaEventSource r=padenot,pehrsons https://hg.mozilla.org/integration/autoland/rev/3712d309915d Set MockCubeb's input channel by parameters r=padenot,pehrsons https://hg.mozilla.org/integration/autoland/rev/78c347ec4800 Switch GraphDriver when a new MediaTrack with max channel is opened r=pehrsons https://hg.mozilla.org/integration/autoland/rev/8b7003a89ed9 Add a test for SetRequestedInputChannelCount r=pehrsons
Comment 7•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d1c33e22f15
https://hg.mozilla.org/mozilla-central/rev/3baf00ec0434
https://hg.mozilla.org/mozilla-central/rev/3712d309915d
https://hg.mozilla.org/mozilla-central/rev/78c347ec4800
https://hg.mozilla.org/mozilla-central/rev/8b7003a89ed9
Description
•