Closed Bug 1735263 Opened 3 years ago Closed 3 years ago

Rework AudioTrackPresent()

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Product:
Core
Component:
Audio/Video: MediaStreamGraph
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(1 file)

Bug 1735263 - Don't count input devices for AudioTrackPresent()'s return
48 bytes, text/x-phabricator-request
Details | Review

In bug 1250934, we block the AudioCallbackDriver switching when we have no active audio track but have an active input device [1]. In theory, if we don't have any active audio track, we should not have any input devices.

The MediaTrackGraph has been refactored in many ways. It's time to re-evaluate if we still need this workaround.

[1] https://searchfox.org/mozilla-central/rev/2c4b830b924f42283632b70f39a60fd36433dd4d/dom/media/MediaTrackGraph.cpp#435-437

Summary: Don't check input devices in AudioTrackPresent() → Rework AudioTrackPresent()

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Type: task → defect

Set release status flags based on info from the regressing bug 1250934

status-firefox93: --- → affected
status-firefox94: --- → affected
status-firefox95: --- → affected
status-firefox-esr78: --- → affected
status-firefox-esr91: --- → affected
Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/897555842d1c
Don't count input devices for AudioTrackPresent()'s return r=padenot

https://hg.mozilla.org/mozilla-central/rev/897555842d1c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: