173532 - Can't print from mail compose

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Akkana Peck]

I was misinformed about the correct way to print in the new editorshell-less
world, and I broke printing for the mail compose window.  Charley is working on
implementing printing, but in the meantime we should just use the old
editorshell methods (patch to follow).

Comment 1

[Akkana Peck]

Attachment: Revert to old code, minus FinishHTMLSource

FinishHTMLSource(), which was in the old code, no longer exists.  Charley, is
there a replacement, or is it kosher not to call it?  Otherwise, this is the
same as the code that was there before, and it does bring up a print dialog. 
Seeking review ...

Looking at what editorshell does, I thought this would do the trick:
  var contentViewer =
gMsgCompose.editor.document.getElementById("content-frame").docShell.contentViewer;

  contentViewer.QueryInterface(Components.interfaces.nsIWebBrowserPrint);
  contentViewer.print(null, null);
but it doesn't work
("gMsgCompose.editor.document.getElementById("content-frame") has no
properties").  Maybe that's a start on rewriting it ...

Comment 2

[Kathleen :Brade]

Comment on attachment 102345 [details] [diff] [review]
Revert to old code, minus FinishHTMLSource

r=brade

if you wanted you could just do this:
 try {
    gMsgCompose.editorShell.Print();
 } catch(ex) {dump...}

Comment 3

[Akkana Peck]

Targeting 1.2beta since this is a regression.

Comment 4

[Akkana Peck]

Seth, can I get an sr?  This just restores what was there before my patch, minus
one line for a call that's been removed from the editor shell and is no longer
needed.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 102345 [details] [diff] [review]
Revert to old code, minus FinishHTMLSource

sr=sspitzer

akkana says she's just reverting.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 102345 [details] [diff] [review]
Revert to old code, minus FinishHTMLSource

a=asa for checkin to 1.2beta (on behalf of drivers)

Comment 7

[Akkana Peck]

Fixed!

Comment 8

[esther]

Using trunk build 20021029 onlinux, 20021028 on winxp and 20021015 on Mac OSX
printing mail messages work. Verified