1735343 - Correct config1 mozilla-central check expectation for moz2d for jumps `data-i` attribute

Status: RESOLVED FIXED

(Webtools :: Searchfox, task)

Description

[Andrew Sutherland [:asuth] (he/him)]

Indexing jobs for config1 failed with:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Differences ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: /home/ubuntu/config/mozilla-central/checks/snapshots/check_glob@rust__first_party__webrender__moz2d__def__html.snap
Snapshot: check_glob@rust__first_party__webrender__moz2d__def__html
Source: tests/test_check_insta.rs:93
-old snapshot
+new results
────────────────────────────────────────────────────────────────────────────────
&aggr_str
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ <div role="row" id="line-277" class="source-line-with-number nesting-sticky-line">
    1     1 │   <div role="cell" class="line-number" data-line-number="277"></div>
    2       │-  <code role="cell" class="source-line"><span class="syn_reserved" >struct</span> <span data-symbols="webrender_bindings::moz2d_renderer::CacheKey" data-i="309" >CacheKey</span> {
          2 │+  <code role="cell" class="source-line"><span class="syn_reserved" >struct</span> <span data-symbols="webrender_bindings::moz2d_renderer::CacheKey" data-i="308" >CacheKey</span> {
    3     3 │ </code>
    4     4 │ </div>
────────────┴───────────────────────────────────────────────────────────────────
To update snapshots run `cargo insta review`
thread 'test_check_glob' panicked at 'snapshot assertion for 'check_glob@rust__first_party__webrender__moz2d__def__html' failed in line 93', /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/insta-1.7.1/src/runtime.rs:1036:9
stack backtrace:
   0: rust_begin_unwind
             at /rustc/5b210643ebf2485aafdf2494de8cf41941a64e95/library/std/src/panicking.rs:517:5
   1: std::panicking::begin_panic_fmt
             at /rustc/5b210643ebf2485aafdf2494de8cf41941a64e95/library/std/src/panicking.rs:460:5
   2: insta::runtime::assert_snapshot
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/insta-1.7.1/src/runtime.rs:1036:9
   3: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   4: std::thread::local::LocalKey<T>::with
   5: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   6: tokio::park::thread::CachedParkThread::block_on
   7: tokio::runtime::thread_pool::ThreadPool::block_on
   8: tokio::runtime::Runtime::block_on
   9: core::ops::function::FnOnce::call_once
  10: core::ops::function::FnOnce::call_once
             at /rustc/5b210643ebf2485aafdf2494de8cf41941a64e95/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

This is probably another reason to switch from using the indexed jumps list to just keying by the symbol and being aware of the line number that the lookup is coming from so that we can suppress the "jump to the definition line you're already on" in that manner instead of pre-computing it in the jumps/searches table.

Alternately, the checks could know to normalize data-i out of existence.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: fix the expectation PR

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

I landed the minimal change and re-triggered config1.