Closed Bug 1735358 Opened 4 months ago Closed 3 months ago

Switch back default devtools theme from auto to light (or dark for deved)

Categories

(DevTools :: CSS and Themes, task, P3)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

With Bug 1670480 there is a concern that this will trigger an unexpected change for users who are in the following configuration:

  • use the DevTools light theme by default
  • use a dark theme for their system/firefox

When they update to a version with Bug 1670480, their DevTools UI will switch from light to dark.

This bug will be about switching back to the previous values for the default preferences temporarily while we figure out a solution to notify impacted users.

Blocks: 1735359
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d4598bfbe3a
[devtools] Switch back default theme from auto to light/dark r=nchevobbe

Backed out for causing mochitest failures on browser_toolbox_theme_registration.js.

Push with failures

Failure log

Backout link

[task 2021-10-15T21:01:24.567Z] 21:01:24     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_theme_registration.js | theme removed from map - 
[task 2021-10-15T21:01:24.567Z] 21:01:24     INFO - Buffered messages finished
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_theme_registration.js | light theme must be selected - Got false, expected true
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - Stack trace:
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - chrome://mochikit/content/browser-test.js:test_is:1364
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_theme_registration.js:themeUnregistration:155
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1091
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1131
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:939
[task 2021-10-15T21:01:24.568Z] 21:01:24     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2021-10-15T21:01:24.569Z] 21:01:24     INFO - Leaving test bound themeUnregistration
[task 2021-10-15T21:01:24.569Z] 21:01:24     INFO - Entering test bound cleanup
[task 2021-10-15T21:01:25.611Z] 21:01:25     INFO - Leaving test bound cleanup
[task 2021-10-15T21:01:25.627Z] 21:01:25     INFO - Removing tab.
[task 2021-10-15T21:01:25.628Z] 21:01:25     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2021-10-15T21:01:25.630Z] 21:01:25     INFO - Got event: 'TabClose' on [object XULElement].
[task 2021-10-15T21:01:25.634Z] 21:01:25     INFO - Tab removed and finished closing
[task 2021-10-15T21:01:25.641Z] 21:01:25     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_theme_registration.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2021-10-15T21:01:25.649Z] 21:01:25     INFO - GECKO(1507) | MEMORY STAT | vsize 9400MB | residentFast 1309MB | heapAllocated 657MB
[task 2021-10-15T21:01:25.649Z] 21:01:25     INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_theme_registration.js | took 1617ms
[task 2021-10-15T21:01:25.657Z] 21:01:25     INFO - checking window state
[task 2021-10-15T21:01:25.661Z] 21:01:25     INFO - TEST-START | devtools/client/framework/test/browser_toolbox_toggle.js
Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/826e696aeeba
[devtools] Switch back default theme from auto to light/dark r=nchevobbe
Flags: needinfo?(jdescottes)
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.