Closed Bug 1735359 Opened 4 months ago Closed 3 months ago

Enable DevTools auto theme by default

Categories

(DevTools :: CSS and Themes, task, P3)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(3 files)

We should show a notification to let users know that the default theme has been updated and that they can change it back by going to the settings.

We might reuse the NotificationBox for this. We might only show this to users with a dark theme.

Attached image notification_box.png

I will be proposing a patch for a one-time notification box which only shows up for users:

  • with a dark chrome color scheme
  • with the auto devtools theme

Once you dismiss the message it will not show up again.

Nicolas, Hubert, what do you think? Would the notification from comment 1 be enough or do we want something more elaborate?

Flags: needinfo?(nchevobbe)
Flags: needinfo?(hmanilla)

Thanks Julian! I think it looks good to reuse the Notification Box for this.
Seeing it, I wonder if we could make it a bit more "positive" though, saying that's a new feature, and maybe having a nicer background-color + icon, something like:

🆕 DevTools now follows the overall Firefox theme. You can revert to Light or Dark theme in the Settings panel.

What do you think?

Flags: needinfo?(nchevobbe)

Sounds good, I'll try to make to visuals a bit nicer :D

That sounds and looks great to me. I also agree on the visual suggestions, making it not too easy to miss.

Thanks

Flags: needinfo?(hmanilla)

What about adding a "Open Settings" button in to the notification box (the NotificationBox has API for that). Users could see the new option and perhaps change it right away.

Attached image image.png

Went with the whatsnew icon here. The background color is the one we use for our "new feature notifications" (multiline console, perf panel).

I notice that the Open Settings button is not particularly pretty against the light background. I am removing the borders in the patch

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f250b7dcde1c
[devtools] Enable DevTools auto theme by default r=devtools-reviewers,nchevobbe

Using the whatsnew.svg image from browser in chrome://devtools is now explicitly forbidden (as of bug 1698112, which is also on autoland). I'm preparing a patch to move the image to toolkit.

Thanks for fixing this Julian!

(In reply to Geoff Lankow (:darktrojan) from comment #11)

Using the whatsnew.svg image from browser in chrome://devtools is now explicitly forbidden (as of bug 1698112, which is also on autoland). I'm preparing a patch to move the image to toolkit.

Thanks for the heads up Geoff. Not sure how we should proceed, if it's easier to backout my patch let me know.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #12)

Thanks for fixing this Julian!

Thanks for doing all the work on this theme, really happy we don't have to delay this!

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Regressions: 1737690
You need to log in before you can comment on or make changes to this bug.