1735359 - Enable DevTools auto theme by default

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P3)

Description

[Julian Descottes [:jdescottes]]

We should show a notification to let users know that the default theme has been updated and that they can change it back by going to the settings.

We might reuse the NotificationBox for this. We might only show this to users with a dark theme.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: notification_box.png

Comment 2

[Julian Descottes [:jdescottes]]

I will be proposing a patch for a one-time notification box which only shows up for users:

• with a dark chrome color scheme
• with the auto devtools theme

Once you dismiss the message it will not show up again.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1735359 - [devtools] Enable DevTools auto theme by default

Comment 4

[Julian Descottes [:jdescottes]]

Nicolas, Hubert, what do you think? Would the notification from comment 1 be enough or do we want something more elaborate?

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Thanks Julian! I think it looks good to reuse the Notification Box for this.
Seeing it, I wonder if we could make it a bit more "positive" though, saying that's a new feature, and maybe having a nicer background-color + icon, something like:

🆕 DevTools now follows the overall Firefox theme. You can revert to Light or Dark theme in the Settings panel.

What do you think?

Comment 6

[Julian Descottes [:jdescottes]]

Sounds good, I'll try to make to visuals a bit nicer :D

Comment 7

[Hubert Boma Manilla (:bomsy)]

That sounds and looks great to me. I also agree on the visual suggestions, making it not too easy to miss.

Thanks

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

What about adding a "Open Settings" button in to the notification box (the NotificationBox has API for that). Users could see the new option and perhaps change it right away.

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: image.png

Went with the whatsnew icon here. The background color is the one we use for our "new feature notifications" (multiline console, perf panel).

I notice that the Open Settings button is not particularly pretty against the light background. I am removing the borders in the patch

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f250b7dcde1c
[devtools] Enable DevTools auto theme by default r=devtools-reviewers,nchevobbe

Comment 11

[Geoff Lankow (:darktrojan)]

Using the whatsnew.svg image from browser in chrome://devtools is now explicitly forbidden (as of bug 1698112, which is also on autoland). I'm preparing a patch to move the image to toolkit.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Thanks for fixing this Julian!

Comment 13

[Julian Descottes [:jdescottes]]

(In reply to Geoff Lankow (:darktrojan) from comment #11)

Using the whatsnew.svg image from browser in chrome://devtools is now explicitly forbidden (as of bug 1698112, which is also on autoland). I'm preparing a patch to move the image to toolkit.

Thanks for the heads up Geoff. Not sure how we should proceed, if it's easier to backout my patch let me know.

Comment 14

[Julian Descottes [:jdescottes]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #12)

Thanks for fixing this Julian!

Thanks for doing all the work on this theme, really happy we don't have to delay this!

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f250b7dcde1c