1735396 - Update test_archive.py expected file hashes when running on Python 3.9 or newer

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michelle Goossens [:masterwayz]]

Python 3.9 has changes in its tar library that we use for this test that changes the file hash we expect.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this is a result of:
https://github.com/python/cpython/pull/18080

specifically in py 3.9, we have this code:
has_device_fields = info.get("type") in (CHRTYPE, BLKTYPE)
if has_device_fields:
devmajor = itn(info.get("devmajor", 0), 8, format)
devminor = itn(info.get("devminor", 0), 8, format)
else:
devmajor = stn("", 8, encoding, errors)
devminor = stn("", 8, encoding, errors)

and prior to this we just had:
devmajor = itn(info.get("devmajor", 0), 8, format)
devminor = itn(info.get("devminor", 0), 8, format)

in our test, we set:
tarinfo.type = REGTYPE

so now we are changing these fields in the header and this is causing our tarfile tobe different.

Comment 2

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1735396 - Update test_archive.py expected file hashes when running on Python 3.9 or newer r=jmaher

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d644badc7844
Update test_archive.py expected file hashes when running on Python 3.9 or newer r=jmaher

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d644badc7844

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/1ccd82971de9