1735476 - ensure that logging for content security checks (CSMLog) is fully conformant YAML

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Description

[Frederik Braun [:freddy]]

Turns out (d'oh), that this is great yaml to list an object:

key: value
key2: value

and this is creating a list single (key, value) objects

- key: value
- key2: value

We want the former.

Comment 1

[Frederik Braun [:freddy]]

Attachment: Bug 1735476 - MOZ_LOG=CSMLog emits contentsecuritycheck as valid yaml r?ckerschb

This commit changes the MOZ_LOG to make the yaml easier to parse,
addressing various shortcomings:

• Firstly, the yaml "document" for a check was an array of dictionaries
  that each contained a single key/value pair. It's now a big dictionary
  containing lots of key/value pairs instead.
• Indentation was wrong for some of the attributes of the content
  security check
• The name key-name for https-only flags was oddly cased

This changeset resolves all of these shortcomings.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38012c0a4ea
MOZ_LOG=CSMLog emits contentsecuritycheck as valid yaml r=ckerschb

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e38012c0a4ea