Closed Bug 1735493 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31211 - FSA: Change RemoveEntry error to NoModificationAllowed

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31211 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31211
Details from upstream follow.

Richard Stotz <rstz@chromium.org> wrote:

FSA: Change RemoveEntry error to NoModificationAllowed

When attempting to delete a file that's currently locked by an Access
Handle, the reported error is "Operation aborted by the user". This CL
changes the error to NoModificationAllowed, which is more descriptive.

Change-Id: I1c620452fbe772d16d8964e1a8714ddb5fb6050f
Bug: 1259565

Reviewed-on: https://chromium-review.googlesource.com/3217394
WPT-Export-Revision: b715941dd6448f8e67affd8759fbf042fa6e648f

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 9 subtests

Status Summary

Firefox

OK : 6
FAIL: 62

Chrome

OK : 6
PASS: 48
FAIL: 14

Safari

OK : 6
FAIL: 62

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker.html
remove() to remove a file: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed file should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() to remove an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a non-empty directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a directory recursively should delete all sub-items: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a file should ignore the recursive option: FAIL (Chrome: PASS, Safari: FAIL)
remove() while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
cannot remove the root of a sandbox file system: FAIL (Chrome: PASS, Safari: FAIL)
/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.html
remove() to remove a file: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed file should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() to remove an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a non-empty directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a directory recursively should delete all sub-items: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a file should ignore the recursive option: FAIL (Chrome: PASS, Safari: FAIL)
remove() while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
cannot remove the root of a sandbox file system: FAIL (Chrome: PASS, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-move.https.any.html
move(dir, name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-move.https.any.worker.html
move(dir, name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-rename.https.any.html
rename(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
rename(dir) should rename to stringified dir object: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
rename(name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-rename.https.any.worker.html
rename(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
rename(dir) should rename to stringified dir object: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
rename(name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02eb1ea3c5be
[wpt PR 31211] - FSA: Change locking error to NoModificationAllowed, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.