1735574 - Clean up a bit meta element handling

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1735574 - Cleanup HTMLMetaElement handling of <meta name content>. r=smaug

This shouldn't change behavior, but I find it a bit easier to reason
about (and should be marginally faster by not doing double attribute
lookups, but not like the should usually matter).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1735574 - Simplify meta viewport handling. r=smaug,botond

We only need the whole array to deal with removals, but other browsers
don't deal with them, see:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_meta_element.cc;l=479;drc=439c6ac35199f3828faf0f0d070d84109c9bf6a1

Given <meta name=viewport> is weird enough as it is, we should probably
do this and simplify the code.

The header data thing was just synonym to "has a meta viewport", so
simplify that code too.

Depends on D128389

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f69838cbf52b
Cleanup HTMLMetaElement handling of <meta name content>. r=smaug
https://hg.mozilla.org/integration/autoland/rev/86e71bf1ba6c
Simplify meta viewport handling. r=smaug

Comment 4

[Atila Butkovits]

Backed out for causing failures at test_meta_viewport_change_name.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c6e924b4cd1ce365f84d9c700d7b48c877dcd0de

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Wp7b8z4gQbywBeRUSuLCNA.1&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=86e71bf1ba6cef915ac48ccdcf7404c0f607d420

Failure log:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5c3fdc0b369
Cleanup HTMLMetaElement handling of <meta name content>. r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/344b6e44f7a8
Simplify meta viewport handling. r=smaug

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a5c3fdc0b369
https://hg.mozilla.org/mozilla-central/rev/344b6e44f7a8