173558 - flawfinder warnings in layout-debug

Status: RESOLVED WONTFIX

(Core :: Layout, defect)

Description

[Stephen P. Morse]

I run flawfinder (http://www.dwheeler.com/flawfinder) on Mozilla 1.0.1 branch.

flawfinder found 1 warnings in layout-debug code (1495). Go through
that list and for each warning:

* If it is false positive, comment here why it is not an issue
* If it is a real issue, make patch for it here and let's get them checked in

In addition to checking the branch, also check the trunk.

1495) extensions/layout-debug/plugin/plugin.cpp:169 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

Comment 1

[Bernd]

this is dcone's stuff

Comment 2

[dcone (gone)]

That code is not being built.. for the branch.  Its under development and the
branch received the beginnings of that piece of work.  I dont think that warning
is worth fixing for the branch..if there is a problem on the trunk.. then that
should be fixed.

Comment 3

[dcone (gone)]

Marking wont fix because the Layout debug is not part of the build for the
branch.. or trunk right now.

Comment 4

[Stephen P. Morse]

See also bug 173850 for more warnings in layout.