1735612 - Perma macOS ESR91 gfx/tests/crashtests/1331683.html | application crashed [@ gfxMacFont::gfxMacFont(RefPtr<mozilla::gfx::UnscaledFontMac> const&, MacOSFontEntry*, gfxFontStyle const*)] after Assertion failure: aVariationCount > 0, at ScaledFontMac.cpp:667

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=354669168&repo=mozilla-esr91
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Btxdyao2T-WywbSGge7Otg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Btxdyao2T-WywbSGge7Otg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

Started happening after we disabled shared font list on ESR91.

Comment 1

[Jonathan Kew [:jfkthame]]

Not specific to ESR91; this also reproduces on trunk if the shared font list is disabled.

It happens because the Skia font has quirky variation-axis scales that we determine don't map to CSS property values, and we end up with an empty array of variations; so we shouldn't assert there, just quietly return null and let the caller fall back to using the base font instance.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1735612 - Don't assert if CreateCGFontWithVariations is called with no variations; just return null and let the caller handle fallback. r?lsalzman

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96bc544cdb62
Don't assert if CreateCGFontWithVariations is called with no variations; just return null and let the caller handle fallback. r=lsalzman

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 9245944 [details]
Bug 1735612 - Don't assert if CreateCGFontWithVariations is called with no variations; just return null and let the caller handle fallback. r?lsalzman

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Perma-failing crashtest on CI
• User impact if declined:
• Fix Landed on Version: 95
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removes over-zealous assertion that was triggered in an edge-case. Just fallback instead.
• String or UUID changes made by this patch:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245944 [details]
Bug 1735612 - Don't assert if CreateCGFontWithVariations is called with no variations; just return null and let the caller handle fallback. r?lsalzman

Approved for 91.3esr, thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/eee06437fffb

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/96bc544cdb62

Comment 8

[Intermittent Failures Robot]

6 failures in 3315 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr91: 6

Platform and build breakdown:

• macosx1015-64-qr: 6
  • debug: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1735612&startday=2021-10-11&endday=2021-10-17&tree=all

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245944 [details]
Bug 1735612 - Don't assert if CreateCGFontWithVariations is called with no variations; just return null and let the caller handle fallback. r?lsalzman

We need this on 94 for bug 1732629 to graft cleanly.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245944 [details]
Bug 1735612 - Don't assert if CreateCGFontWithVariations is called with no variations; just return null and let the caller handle fallback. r?lsalzman

Needed for bug 1732629, approved for 94.0rc2.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/77ce2fd8af4a