1735613 - Fix android test NavigationDelegateTest#redirectIntentLoad when parent-controlled path is enabled in GeckoView

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Comment 1

[Anny Gakhokidze [:annyG]]

Pasting this comment for details:

I forgot to follow up here, but I had a meeting with nika and she pointed out how it could be related to an existing problem we know about where if a redirection fails to take place, we don't revert back the mChannelCreationURI in DocumentLoadListener (which Matt you mentioned in another bug). I briefly tried to add a channelCreationURI getter to nsIChannel where it returns the value of OriginalURI at the time AsyncOpen method was called, and even though this specific android test was fixed, there were a lot of other test issues that I need to look at.

Considering how we want to enable parent-controlled pref only if session history in parent is enabled, this test will not be an issue anymore since we don't have SHIP enabled on android. Therefore, I filed a follow up bug 1735613 to fix this test where I will address the problem of mChannelCreationURI not being reverted back.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Anny Gakhokidze [:annyG]]

<this was a draft comment which only got posted because I changed the title of the bug and didn't clear the comment text field>

Comment 4

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1735613 - Part 1: Remove the requirement for SHIP with parent controlled loads, r=peterv!,nika!

Comment 5

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1735613 - Part 2: When redirecting in Document Channel, use the correct URI, r=nika!

Depends on D132092

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/971d630dd09a
Part 1: Remove the requirement for SHIP with parent controlled loads, r=peterv,nika
https://hg.mozilla.org/integration/autoland/rev/e766f7d97e3e
Part 2: When redirecting in Document Channel, use the correct URI, r=nika

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/971d630dd09a
https://hg.mozilla.org/mozilla-central/rev/e766f7d97e3e

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.