Make installer check and detect if an installation is already happening
Categories
(Firefox :: Installer, enhancement, P5)
Tracking
()
People
(Reporter: Vonbrom58, Unassigned)
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0
Steps to reproduce:
I launched firefox twice by accident and it installed firefox twice so I had two firefox browsers inside a virutal machine
Actual results:
I had two firefox browsers on my virtual machine
Expected results:
one installer should have detected an install happening and stop
|
Reporter | |
Comment 1•3 years ago
|
||
The report was sent on my host pc so the user agent could be wrong, I installed firefox on the virtual machine running windows 10 version 1909 with an OS build of 18363.418 on Oct, 13, 2021 at around 9 PM
|
||
Comment 2•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Installer' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Updated•3 years ago
|
|
||
Comment 3•3 years ago
|
||
It's a decent amount of effort to detect a concurrent installation and it opens the door to many complications. Scarecrow: we take an OS-level mutex and rely on Windows to release it. But the stub installer launches the full installer, so they need to coordinate, and different versions of Firefox can be installed concurrently...
All in all I don't think we should try to prevent concurrent installation like this. We don't want to lock users out of installation accidentally, and in the given case it appears that both installations were functional, so presumably one could be uninstalled. I'm not even sure I'd take a patch (i.e., if this should be P5 instead of WONTFIX). But let's leave it in case others have counterarguments.
Thanks for the suggestion, vonbrom.
|
||
Updated•3 years ago
|
Description
•