Closed
Bug 1735862
Opened 3 years ago
Closed 3 years ago
Verify js/public/friend/ErrorNumbers.msg has no preprocessor
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
bug 1729563 patch hit issue because it contained preprocessor inside js/public/friend/ErrorNumbers.msg .
ErrorNumbers.msg is used in the 2 case:
- included from C++ code
- parsed by python script https://searchfox.org/mozilla-central/rev/46ff2252568db36e811109fa4026c8e3c12e9ee1/js/src/builtin/embedjs.py#158-167
The latter doesn't recognize proprocessor, but just ignores it.
that can result in inconsistency between C++ and self-hosted JS.
js/src/builtin/embedjs.py should check if the msg file doesn't contain any preprocessor, and throws error otherwise.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/c886427cfe62 Disallow preprocessor in ErrorNumbers.msg. r=mgaudet
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•